Fix double binding causing game crash after API enters failing state #27754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Mar 29, 2024
Comment on lines
75
to
76
| userStatus.BindTo(api.LocalUser.Value.Status); | ||
| userStatus.BindValueChanged(e => updateDropdownCurrent(e.NewValue), true); |
There was a problem hiding this comment.
This is not correct though now is it?
api.LocalUser.Value.Status is a bindable field under a bindable. api.LocalUser will change value after e.g. a log-out and a log-in. Upon which userStatus will not be bound to api.LocalUser.Value.Status anymore, it will be bound to the old user's Status bindable.
There was a reason this was placed where it was placed.
There was a problem hiding this comment.
Yep, you got that one correct. Pretty annoying usage of bindables here, will adjust.
bdach
approved these changes
Mar 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email