Rename SkinComponentsContainer -> SkinnableContainer #27932
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will not accept this type existing with its current name any longer. We currently have the following types:
The naming of
SkinComponentsContainer
is confusing because it implies that it andSkinnableDrawable
are totally different from one another, whereas they act pretty much the same way - both viaSkin.GetDrawableComponent()
. One just returns aContainer
and one aDrawable
.Of course,
SkinnableDrawable
has some extra cruft that it really should not have, but I won't address that for now.The structure I eventually want to end up with is: