Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a chevron to distinguish editor menus with submenus #27974

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Apr 23, 2024

Closes #27916.

Before After
2024-04-23 21 34 46@2x 2024-04-23 21 36 37@2x

@bdach bdach merged commit a35bf77 into ppy:master Apr 23, 2024
15 of 17 checks passed
@LittleLilyBun
Copy link

I'd hate to be a bother, but this doesn't seem to apply to right-click menus in the skin editor, is this intentional?
image

@Joehuu
Copy link
Member

Joehuu commented Apr 23, 2024

Shouldn't be. The chevron was added very locally (specific to the top editor menus). Probably for just less effort.

Ideally, this should be done in DrawableOsuMenuItem or even framework-side (as a default) as it is a crucial context menu UX.

@peppy
Copy link
Sponsor Member Author

peppy commented Apr 24, 2024

Ideally, this should be done in DrawableOsuMenuItem or even framework-side (as a default) as it is a crucial context menu UX.

That comes with further considerations (doing it there requires blocking it from being displayed in other cases, at very least). I'm not against making it work there though – let me know if you're taking that on.

@Joehuu
Copy link
Member

Joehuu commented Apr 24, 2024

I'll try tackling that in DrawableOsuMenuItem for now.

@peppy peppy deleted the editor-menu-chev branch April 25, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve map editor dropdowns
4 participants