Completely disable Velopack when using an external updater #29805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Sep 9, 2024
osu.Desktop/Program.cs
Outdated
| @@ -169,6 +169,14 @@ private static bool trySendIPCMessage(IIpcHost host, string cwd, string[] args) | |||
|
|
|||
| private static void setupVelopack() | |||
| { | |||
| string? packageManaged = Environment.GetEnvironmentVariable("OSU_EXTERNAL_UPDATE_PROVIDER"); | |||
There was a problem hiding this comment.
Can this be moved to a common (static) location so that it's not referenced twice by name in two different places?
peppy
approved these changes
Sep 9, 2024
peppy
added
the
next release
smoogipoo
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will completely disable Velopack if
OSU_EXTERNAL_UPDATE_PROVIDERis provided. The morale for this PR was caesay's reponse here.Testing Checklist
(added a custom logger to notify if setup runs correctly)
Opening as a draft since I haven't tested it yet & have to fix conflicts, but I'll get around to it soon.