Add support for ruleset-specific blueprints in editor timeline #29973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. This PR allows rulesets to customize how hit objects are represented in the timeline without having to modify the hit object classes or create additional interfaces.
The need for this has been expressed multiple times already in #29441 and #21566
The API is a bit limited because it expects objects of type
TimelineHitObjectBlueprint
which already defines all the layout and interactions. If more freedom is required, I thinkTimelineHitObjectBlueprint
should not define layout and instead the parts of it should be split into separate classes which could be composited instead.As an example I've implemented two ruleset-specific changes that make use of this API:
The
IHasDisplayColour
interface can also be eliminated in favour of taiko specific timeline blueprints.