Add "Blinds" mod #3180

WebFreak001 · 2018-08-05T11:38:44Z

Adds a new mod which is similar to flashlight but is based on the HP. This also adds an Overlays container to RulesetContainer which is always drawn above hit objects. It allows to implement Flashlight more easily in the future.

Basically the mod is 2 blinds which open and close depending on your HP. Maybe actual blinds textures could be added in the future, but it's only black for now. Currently only for standard mode. I could imagine this in Mania (1 vertical blind). CTB and Taiko could probably even use the same.

Old Video [9.8 MiB]: https://wfr.moe/fDEJkH.mp4
Old Video 2 [9.9 MiB]: https://wfr.moe/fiBhQw.mp4
Old Video 3 [9.8 MiB]: https://wfr.moe/fiQlYa.mp4
Current Video [9.9 MiB]: https://wfr.moe/fiJPrG.mp4

this is required for mods such as flashlight which always want to draw objects above hitcircles. If just adding children to a RulesetContainer the hit circles would always be above the added children (no matter the Depth).

WebFreak001 · 2018-09-15T20:58:59Z

I think it's more fun with textures than black and it transports the meaning and the thought behind the mod a lot more clearly.

Here is the texture which I made for this: ~~wfr.moe/fiB3rM/osu.Game.Resources/Textures/Play/osu/blinds-panel.png~~ (outdated, check comment with embed below)

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs

+            });
+
+            this.skin = skin;
+            skin.SourceChanged += skinChanged;


There are now skinnable actual blinds (shoji screen panels) The black overlay is still behind them to avoid cheating with skins The blinds don't open linearly anymore, they are health squared now When easy mod is on, there is always a little gap open

WebFreak001 · 2018-09-15T22:39:07Z

This is the video how it currently looks (if you add that resource) linked in the comment above both without EZ and with EZ: [9.9 MB] https://wfr.moe/fiBhQw.mp4

holly-hacker · 2018-09-15T23:23:19Z

Continuing the discussion from Discord: perhaps you could make it so HR adds 1 circle's diameter as offset to the blind opening (which gets clamped for drawing), so your health will have to drop to some value below 100% for the blinds to open? Same would go for EZ but in reverse: exactly 1 circle's diameter would be visible at 100% health. This should again add some more depth to the mod and will make the difficulty scale somewhat with CS.

As for the current distance scaling algorithm, perhaps a power of 2 is a bit too much for nomod. This very much depends on the current HP algo (which may change in the future), but scaling this power depending on the current mod or OD value could be an idea. Perhaps n^1.5 for EZ, n^1 for HR, n^1.166 for nomod?

It'll probably take a bunch of playtesting to get these right and I haven't tried it myself yet, so do take everything I suggest with a grain of salt.

WebFreak001 · 2018-09-16T09:09:57Z

well if CS is becoming a per circle property instead of a per map property I can't really use it here. OD would be a possibility for the curve. Maybe also include it in the gap calculation, but only with the mods EZ or HR on because they actually change the score multiplier to something more extreme which should actually make it that extreme.

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs

+        /// <summary>
+        /// Black background boxes behind blind panel textures.
+        /// </summary>
+        private Box box1, box2;


osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs

+                Width = 512 * 0.4f,
+                Height = 512 * 0.95f,
+                RelativePositionAxes = Axes.Y,
+                X = -512,


osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs

+
+        private float applyGap(float value)
+        {
+            float ret;


osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs

+            PanelTexture = skin.GetTexture("Play/osu/blinds-panel");
+        }
+
+        private float applyGap(float value)


osu.Game.Rulesets.Osu/Objects/Drawables/Pieces/ModBlindsPanelSprite.cs

+        protected override void Update()
+        {
+            Height = Parent?.DrawHeight ?? 0;
+            if (Height == 0 || Texture is null)


osu.Game/Rulesets/Mods/ModBlinds.cs

+    {
+        public override string Name => "Blinds";
+        public override string ShortenedName => "BL";
+        public override FontAwesome Icon => FontAwesome.fa_osu_mod_flashlight;


WebFreak001 · 2018-09-16T15:38:59Z

here is my current blinds texture with semi transparent panels which looks nice when it overlaps and the npc walks behind them:

Outdated Panel texture

peppy · 2018-10-10T10:53:56Z

Really love the added doors! It takes this mod from being pretty lame to being something quite unique.

WebFreak001 · 2018-10-10T11:59:53Z

should I make a PR to osu-resources to add the blinds texture?

peppy · 2018-10-10T12:14:50Z

Don't just yet, we'll do a pass on them (@arflyte may have something to say).

arflyte · 2018-10-12T05:51:58Z

I suggest changing the wooden part to brown with faint wooden texture. Currently, the paper texture looked like a wallpaper's; suggest changing that to a paper texture with a warmer tint.

WebFreak001 · 2018-10-12T09:31:56Z

yeah the paper part is currently just white with the normal map of a wallpaper because I don't have any paper/fabric normal maps. I thought something like that would fit because it is basically just noise (as heightmap) in the end. Proper paper textures are kind of hard to generate in comparison.

WebFreak001 · 2018-10-12T13:45:35Z

@arflyte tried paper texture now, added a new wood texture and used a warmer (in-door) HDR instead of studio lighting:

ingame screenshot: https://wfr.moe/frfAy8.png

Updated

peppy · 2018-10-12T15:20:32Z

Are you able to explain what the fruit catcher is doing in this mod? I don't really understand.

WebFreak001 · 2018-10-12T15:22:14Z

It is just a random character going in and out. Gameplay wise it reveals parts of the playfield for just a brief period of time if you are doing well (combo-wise) so that it isn't completely memorizing a map.

Changes how OsuModBlinds passes the playfield and how DrawableOsuBlinds handles the restrictTo parameter.

WebFreak001 · 2018-12-06T15:39:23Z

I have removed the catcher sprite for now

peppy · 2018-12-14T11:53:17Z

Was looking at getting this in but having issues making the door resource small enough to include.

WebFreak001 · 2018-12-14T18:33:02Z

If lossy compression is ok, the image could be compressed to webp with 90% quality being 877 KB with the 1310x2048 resolution. Lossy compression of png with pngquant --speed=1 gives me a 1.6 MB file. With crunch I could make it 1.5 MB

Both look nearly the same and look perfectly fine for ingame usage:
original [4.4 MiB] (100%)
pngquant [1.6 MiB] (35.2%)
crunch [1.5 MiB] (32.8%)
webp (external link) [857.2 KiB] (18.9%)

johnneijzen · 2018-12-16T07:49:29Z

hmm I tried to compress image software i used was FileOptimizer

Lossless Version 3.37 MB
Lossy Version 752 KB

peppy · 2018-12-20T06:03:35Z

Let's go with the lossy one for now. We probably need to rethink the texture ing general and the current may not be the final design, so best to get something in for now.

Not sure if we want this going forward.

We decided that mods shouldn't be interacting with other mods. This can be added once we have the ability to have per-mod settings, as a difficulty setting local to blinds.

peppy

ok

WebFreak001 added 2 commits August 5, 2018 13:12

added Overlays container to RulesetContainer

b011edd

this is required for mods such as flashlight which always want to draw objects above hitcircles. If just adding children to a RulesetContainer the hit circles would always be above the added children (no matter the Depth).

Implement blinds mod

b33954d

WebFreak001 force-pushed the mod-fl2 branch from 336ccc9 to b33954d Compare August 5, 2018 12:22

smoogipoo added ruleset/osu! area:mods proposal labels Aug 8, 2018

Merge branch 'master' of github.com:WebFreak001/osu into mod-fl2

040a44d

WebFreak001 commented Sep 15, 2018

View reviewed changes

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs Outdated

});

this.skin = skin;

skin.SourceChanged += skinChanged;

This comment was marked as off-topic.

Sign in to view

WebFreak001 force-pushed the mod-fl2 branch from 858c753 to 5f3c054 Compare September 15, 2018 21:44

WebFreak001 added 2 commits September 16, 2018 12:48

Make fruit catcher enter and leave what's behind the blinds

91b2587

Style & const fix

633e8fa

miterosan suggested changes Sep 16, 2018

View reviewed changes

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuBlinds.cs Outdated Show resolved Hide resolved

miterosan suggested changes Sep 16, 2018

View reviewed changes

WebFreak001 added 2 commits September 16, 2018 16:51

Made blinds open during breaks and start

c9ea5ce

Readonly fixes

2de3b33

WebFreak001 and others added 2 commits September 17, 2018 20:31

Make random in blinds mod the same every replay

8a01fc1

Merge branch 'master' into mod-fl2

e0a8157

Merge branch 'master' into mod-fl2

460c943

WebFreak001 added 7 commits October 27, 2018 16:34

Merge branch 'master' of https://github.com/ppy/osu into mod-fl2

3b08ad0

Changes how OsuModBlinds passes the playfield and how DrawableOsuBlinds handles the restrictTo parameter.

Adjust blinds animations based on player feedback

72e82b6

Merge branch 'master' of https://github.com/ppy/osu into mod-fl2

cbd14d5

Merge branch 'master' of https://github.com/ppy/osu into mod-fl2

3cb9197

make target animation call more obvious

46b9870

Remove blinds random NPC

a14de5b

Style fixes

6eff7d9

Merge branch 'master' into mod-fl2

808f02b

peppy changed the title ~~New Blinds mod~~ Add "Blinds" mod Dec 7, 2018

peppy added 3 commits December 7, 2018 20:12

Remove unnecessary base class

d379d02

Remove unnecessary private field

7d9cdf6

Major code refactors

4f34d42

peppy added 5 commits December 20, 2018 15:47

Update resources

07f8b8e

Remove skinnability for now

bb850da

Not sure if we want this going forward.

Merge branch 'master' into mod-fl2

9177a45

Simplify changes to RulesetContainer

d3368df

Remove mod multipliers

ef9d93f

We decided that mods shouldn't be interacting with other mods. This can be added once we have the ability to have per-mod settings, as a difficulty setting local to blinds.

peppy approved these changes Dec 20, 2018

View reviewed changes

Merge branch 'master' into mod-fl2

ce414ed

peppy merged commit f195d6c into ppy:master Dec 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Blinds" mod #3180

Add "Blinds" mod #3180

WebFreak001 commented Aug 5, 2018 •

edited

WebFreak001 commented Sep 15, 2018 •

edited

This comment was marked as off-topic.

WebFreak001 commented Sep 15, 2018 •

edited

holly-hacker commented Sep 15, 2018

WebFreak001 commented Sep 16, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

WebFreak001 commented Sep 16, 2018 •

edited

peppy commented Oct 10, 2018 •

edited

WebFreak001 commented Oct 10, 2018

peppy commented Oct 10, 2018

arflyte commented Oct 12, 2018

WebFreak001 commented Oct 12, 2018

WebFreak001 commented Oct 12, 2018 •

edited

peppy commented Oct 12, 2018

WebFreak001 commented Oct 12, 2018

WebFreak001 commented Dec 6, 2018

peppy commented Dec 14, 2018

WebFreak001 commented Dec 14, 2018 •

edited

johnneijzen commented Dec 16, 2018

peppy commented Dec 20, 2018

peppy left a comment

Add "Blinds" mod #3180

Add "Blinds" mod #3180

Conversation

WebFreak001 commented Aug 5, 2018 • edited

WebFreak001 commented Sep 15, 2018 • edited

This comment was marked as off-topic.

WebFreak001 commented Sep 15, 2018 • edited

holly-hacker commented Sep 15, 2018

WebFreak001 commented Sep 16, 2018

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

WebFreak001 commented Sep 16, 2018 • edited

peppy commented Oct 10, 2018 • edited

WebFreak001 commented Oct 10, 2018

peppy commented Oct 10, 2018

arflyte commented Oct 12, 2018

WebFreak001 commented Oct 12, 2018

WebFreak001 commented Oct 12, 2018 • edited

peppy commented Oct 12, 2018

WebFreak001 commented Oct 12, 2018

WebFreak001 commented Dec 6, 2018

peppy commented Dec 14, 2018

WebFreak001 commented Dec 14, 2018 • edited

johnneijzen commented Dec 16, 2018

peppy commented Dec 20, 2018

peppy left a comment

Choose a reason for hiding this comment

WebFreak001 commented Aug 5, 2018 •

edited

WebFreak001 commented Sep 15, 2018 •

edited

WebFreak001 commented Sep 15, 2018 •

edited

WebFreak001 commented Sep 16, 2018 •

edited

peppy commented Oct 10, 2018 •

edited

WebFreak001 commented Oct 12, 2018 •

edited

WebFreak001 commented Dec 14, 2018 •

edited