Refactor skin configuration lookups to be more flexible #5969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
changed the title
|
Conflicts: osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableDrawable.cs
smoogipoo
previously approved these changes
Sep 5, 2019
|
@peppy review my latest changes, otherwise seems good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rulesets can now define configuration enums as they wish. Note that namspacing has not yet been added, but this is unnecessary for current legacy implementations (and will be added in the near future).
Removes ugly delegate-based configuration lookups which were prone to error in null/fallback handling.