Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight spotlight timeshift rooms with special colour #9493

Merged
merged 7 commits into from
Jul 10, 2020

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jul 10, 2020

@smoogipoo
Copy link
Contributor

Fails on creating room with:

2020-07-10 10:47:39 [verbose]: ---> System.ArgumentNullException: Value cannot be null. (Parameter 'value')
2020-07-10 10:47:39 [verbose]: at System.Enum.ToObject(Type enumType, Object value)
2020-07-10 10:47:39 [verbose]: at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType)

Is this what's expected - to have a nullable value here? I'd expect to receive "normal".

@peppy
Copy link
Sponsor Member Author

peppy commented Jul 10, 2020

Normal sounds better as a default, yep.

@peppy peppy merged commit b59183d into ppy:master Jul 10, 2020
@peppy peppy deleted the highlight-spotlight-rooms branch July 10, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants