Update iOS game display link to prefer high frame rates #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sense of this range on previous phones where the limit is 60hz.
peppy
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the game view and display link to use the newly introduced
CAFrameRateRanges with a high frame rate range selected (60 minimum, 120 maximum, 120 preferred), allowing iPhone 13 Pro and iPhone 13 Pro Max with the ProMotion display to reach up to 120 fps in game, as confirmed in ppy/osu#15721 (comment).I've also removed the obsolete
Run(int preferredFramesPerSecond)as it looks to be pretty unnecessary here.