Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to open source? #62

Closed
erquhart opened this issue Jun 13, 2018 · 12 comments
Closed

Any plans to open source? #62

erquhart opened this issue Jun 13, 2018 · 12 comments

Comments

@erquhart
Copy link

Hi there - great project! Looks like the actual source is kept offline and only the build files are being added to this repo. If you open source it, the community can help make it better. Any plans to do that?

@rikschennink
Copy link
Collaborator

Thanks! The plan is to release the source later this year.

To be able to better facilitate pull requests and new ideas I want to have more unit tests and need to restructure the repository. Without that, it'll cost way too much time to support incoming improvements/suggestions so therefore I've currently only released the build targets.

@paukul
Copy link

paukul commented Jun 19, 2018

With full respect for your decision, I gotta say it's quite frustrating to figure out what's happening in the source when something isn't working out as expected right now. Can't you handle the constraints on your time with a disclaimer in the readme? Access to the vanilla code would working with this great library way, way easier ;-)

@rikschennink
Copy link
Collaborator

rikschennink commented Jun 20, 2018

I understand, I’m trying to get this done ASAP but it’s not the only thing on my plate. I’d rather not have pull request than have pull requests I can’t review, judging from the quality of certain issues a simple entry in the readme would not be enough.

@Sopamo
Copy link
Contributor

Sopamo commented Feb 26, 2019

I'd like to throw in my two cents here. I'm currently implementing filepond into one of our projects. The UI is really nice.
However not being able to look at the source makes things really difficult from time to time and also leaves a bad aftertaste, because it seems like you somehow don't want this to be open source at all. I can understand your decision regarding pull requests, but I'd really like you to reconsider this, I think not having the source available really hinders the progress of this great project.

@rikschennink
Copy link
Collaborator

I hear you @Sopamo

because it seems like you somehow don't want this to be open source at all

This is not helping. If I didn't want it to be open source I would've stated that in an earlier comment.

@Sopamo
Copy link
Contributor

Sopamo commented Mar 1, 2019

After reading my comment again I realized it didn't sound as I meant it. I tried to explain, that without reading your comment on this issue it seems like you don't want this project to be open source. The problem is, that almost no one will ever read your comment here, so people will wonder why the project isn't open source and probably won't come to the correct conclusion. Maybe you could at least link this issue in the readme?

@rikschennink
Copy link
Collaborator

@Sopamo Excellent idea I will do that right away.

Thanks for building a Laravel FilePond server!

@Sopamo
Copy link
Contributor

Sopamo commented Mar 1, 2019

I'm happy to support this great project :) I actually wanted to wait a bit to test the code more before telling you about it and maybe asking if you could link it in the readme, so Laravel people would find it quickly.

@rikschennink
Copy link
Collaborator

@Sopamo If you wish I can remove the link (I added it to the README as well, hadn't read your reply).

@Sopamo
Copy link
Contributor

Sopamo commented Mar 1, 2019

It's fine I guess, the code isn't very complex and works fine for our project.
Sorry guys, I'll stop spamming this issue now with irrelevant comments :)

@rikschennink
Copy link
Collaborator

I've started with open sourcing the plugins, they should all be open source in the next few weeks.
https://github.com/pqina/filepond-plugin-file-encode

@rikschennink rikschennink reopened this Mar 22, 2019
@rikschennink
Copy link
Collaborator

I just published version 4.3.4 of FilePond, with this release all plugins and FilePond itself are now truly open source.

👉 https://twitter.com/rikschennink/status/1110154018758770692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants