-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should not require the reference field #76
Comments
Would it be better to allow disabling the reference checker specifically, and leave it on by default? |
Hmm... I guess I'm not sure. Either way I do think it should be an option the way fully disabling validation is now. |
Yes, I think the recommendation for now would be to turn off all the validation. So, I think we should break the validation into related chunks that can be turned on or off as desired. As part of that, the reference checking can be turned off. The question then is whether it should be on or off by default. I think I would prefer on by default, but its not a strong preference. I think this is actually a duplicate of #39 then. |
OK, I think it is. We can continue the conversation there. |
I'm going to reopen this because I think it merits a bit more discussion. So I looked at the schema, and I thought the only required fields were year and authors, but it turns out journal is also required. So I propose leaving the |
OK, this seems fine. It seems reasonable to keep |
As pointed out by a reviewer for our IJCK submission, we want people to use the ChemKED format internally and submit alongside articles. This is impossible right now, because we require a reference.
I propose that we remove
reference
from the required list of fields. It should still be required when submitting something to our database, though.The text was updated successfully, but these errors were encountered: