Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The autoScroll property of the TimelineCard component #120

Open
edc-hui opened this issue Mar 24, 2021 · 8 comments
Open

The autoScroll property of the TimelineCard component #120

edc-hui opened this issue Mar 24, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@edc-hui
Copy link

edc-hui commented Mar 24, 2021

The autoScroll property of the TimelineCard component props needs to be turned on at the developer's discretion. My current requirement here is that Autoscroll cannot be used.

My English is not very good, I wonder if you can understand。

@edc-hui
Copy link
Author

edc-hui commented Mar 24, 2021

AutoScroll props, the component of TimelineCard, needs to be released for the developer to decide whether it is necessary to apply for it or not. Currently, I do not need to use this props from my side.

@prabhuignoto prabhuignoto self-assigned this Mar 24, 2021
@prabhuignoto prabhuignoto added this to the 1.9.3 milestone Mar 24, 2021
@prabhuignoto prabhuignoto added the enhancement New feature or request label Mar 24, 2021
@prabhuignoto
Copy link
Owner

@edc-hui will be adding a new prop useReadMore. The prop can be used to switch off the read more functionality and the card will expand to fit the content. hope this would resolve the problem you are facing.

@prabhuignoto prabhuignoto linked a pull request Mar 27, 2021 that will close this issue
@edc-hui
Copy link
Author

edc-hui commented Mar 30, 2021

@prabhuignoto when the mode is horizontal and the card content is too high, the page will automatically scroll down. Now the goal is not to scroll. Because of multiple cards, some cards are high and some cards are low, switching back and forth will cause a bad interactive experience.
what should i do please

@edc-hui
Copy link
Author

edc-hui commented Mar 31, 2021

@prabhuignoto
file path : src/components/timeline-elements/timeline-card-content/timeline-card-content.tsx .
this file has lines 160 and 167 that are commented out, so I can use a props to determine the execution of this line of code.
Will you consider it?
specific code: “containerRef.current && containerRef.current.focus()”

@prabhuignoto
Copy link
Owner

@prabhuignoto when the mode is horizontal and the card content is too high, the page will automatically scroll down. Now the goal is not to scroll. Because of multiple cards, some cards are high and some cards are low, switching back and forth will cause a bad interactive experience.
what should i do please

have you tried using the cardHeight to set a fixed height. This along with the new useReadMore prop might mitigate this problem

@prabhuignoto
Copy link
Owner

@prabhuignoto
file path : src/components/timeline-elements/timeline-card-content/timeline-card-content.tsx .
this file has lines 160 and 167 that are commented out, so I can use a props to determine the execution of this line of code.
Will you consider it?
specific code: “containerRef.current && containerRef.current.focus()”

sorry i didn't understand your questions. can you elaborate the problem you are facing.

@prabhuignoto prabhuignoto removed a link to a pull request Apr 2, 2021
@prabhuignoto
Copy link
Owner

prabhuignoto commented Apr 12, 2021

@edc-hui did the new updates 1.9.3 help you to solve the problem. let me know

@edc-hui
Copy link
Author

edc-hui commented Apr 14, 2021

@prabhuignoto
sorry recently too busy to reply in time . after the test 1.9.3 , It didn't solve my problem. i can't using the cardHeight to set a fixed height, because the card height is not fixed in my project. When I remove this line of code that "containerRef.current && containerRef.current.focus()", it solved the problem I ran into. And the location of this line of code
file path : src/components/timeline-elements/timeline-card-content/timeline-card-content.tsx .

@prabhuignoto prabhuignoto removed this from the 1.9.3 milestone Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants