Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable timeline point selection #170

Closed
ngmarcus opened this issue Sep 8, 2021 · 4 comments · Fixed by #199
Closed

Option to disable timeline point selection #170

ngmarcus opened this issue Sep 8, 2021 · 4 comments · Fixed by #199
Assignees
Labels
enhancement New feature or request

Comments

@ngmarcus
Copy link

ngmarcus commented Sep 8, 2021

This is a feature request.

In the "VERTICAL" or "VERTICAL_ALTERNATING" mode, perhaps a prop can be added to the Chrono component to disable the selection of a point in the timeline.

In the following example, the top-most point is being selected. I am hoping to disable this.

Screen Shot 2021-09-09 at 2 16 28 AM

Thanks!

@prabhuignoto prabhuignoto self-assigned this Sep 8, 2021
@prabhuignoto prabhuignoto added the enhancement New feature or request label Sep 8, 2021
@prabhuignoto
Copy link
Owner

@marcus2k is there a specific reason why you want to disable the timeline point selection.

@prabhuignoto prabhuignoto modified the milestones: 1.12, 1.13 Nov 3, 2021
@PedroSilva8
Copy link

Personally, I want to use Chrono as a simple timeline, I have no need for the point selection, I also believe there should be an option to disable it, when I have the timeline vertically and disable controls there really isn't any use for the point selection

@Edward-Phillips
Copy link

+1 to this, I would love a prop to disable timeline point selection. Also I just want to say this is a great component 🙌 thanks for the work you do

@prabhuignoto prabhuignoto linked a pull request Dec 28, 2021 that will close this issue
@prabhuignoto prabhuignoto mentioned this issue Dec 29, 2021
prabhuignoto added a commit that referenced this issue Dec 29, 2021
Fixes the following issues

#186
#179
#170
#176
#168
@prabhuignoto
Copy link
Owner

prabhuignoto commented Dec 30, 2021

the point selection can be disabled via disableClickOnCircle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants