Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useReadMore on element basis #179

Closed
gutsytechster opened this issue Nov 2, 2021 · 2 comments · Fixed by #199
Closed

useReadMore on element basis #179

gutsytechster opened this issue Nov 2, 2021 · 2 comments · Fixed by #199
Assignees

Comments

@gutsytechster
Copy link

Is your feature request related to a problem? Please describe.
At times, there is a very small description for some of the cards in a timeline. However, the read more is still shown to the user. It is being used where the description is long, but for one-liner detailed text, it is not required.

Describe the solution you'd like
We can specify this prop on each element of the items prop, or if it can automatically adds it based on the cardHeight + the amount of content to be shown.

Describe alternatives you've considered
An alternative is to define the custom content, to remove the read more text.

Additional context
If there is any other solution that I am not aware of, please let me know.

Thank you for your work. I found this project very helpful and easy to use. I am not into Frontend much, but it was easier for me to integrate this into my portfolio.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Hey there! Welcome to react-chrono

@prabhuignoto prabhuignoto self-assigned this Nov 2, 2021
@prabhuignoto prabhuignoto added this to the 1.13 milestone Nov 3, 2021
@prabhuignoto prabhuignoto linked a pull request Dec 28, 2021 that will close this issue
@prabhuignoto prabhuignoto mentioned this issue Dec 29, 2021
prabhuignoto added a commit that referenced this issue Dec 29, 2021
Fixes the following issues

#186
#179
#170
#176
#168
@prabhuignoto
Copy link
Owner

This is now fixed with 1.13. The read more link only appears if the text content exceeds the card height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants