Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9 changes #94

Merged
merged 11 commits into from
Jan 17, 2021
Merged

1.9 changes #94

merged 11 commits into from
Jan 17, 2021

Conversation

prabhuignoto
Copy link
Owner

@prabhuignoto prabhuignoto commented Jan 16, 2021

  • Code refactored to pass Top level props to all Functional components via context provider.

  • cardDetailedText will now also accept string of arrays. The array is split and placed as a separate text blocks.

       cardDetailedText: ['text1', 'text2]

    image

  • Support for adding custom icons in the Timeline.

    image
    image

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

src/demo/app-samples.tsx Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2021

This pull request introduces 5 alerts when merging 50715dc into 1cb6417 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

@prabhuignoto prabhuignoto self-assigned this Jan 16, 2021
@prabhuignoto prabhuignoto added this to the 1.9.0 milestone Jan 16, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2021

This pull request introduces 3 alerts when merging 0fbf3a3 into 1cb6417 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@prabhuignoto prabhuignoto changed the title refactor: removed prop drilling 1.9 changes Jan 16, 2021
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

src/demo/app-samples.tsx Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2021

This pull request introduces 1 alert when merging 51e5ad4 into 1cb6417 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

src/demo/app-samples.tsx Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2021

This pull request introduces 1 alert when merging 15f6231 into 1cb6417 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@prabhuignoto prabhuignoto marked this pull request as draft January 17, 2021 15:18
@prabhuignoto prabhuignoto marked this pull request as ready for review January 17, 2021 15:23
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@@ -335,6 +342,40 @@ The items collection will also work nicely with any custom content that is passe
</Chrono>
```

### 🎭 Custom icons for the Timeline

To use custom icons in the timeline, pass in the collection of images between the `chrono` tags wrapped in a container.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

### 🎭 Custom icons for the Timeline

To use custom icons in the timeline, pass in the collection of images between the `chrono` tags wrapped in a container.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

</div>
</chrono>
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.


>custom icons also works if you are [rendering custom content](#rendering-custom-content) inside the cards.

```sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

>custom icons also works if you are [rendering custom content](#rendering-custom-content) inside the cards.

```sh
<Chrono mode="VERTICAL" items={items}>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.


To use custom icons in the timeline, pass in the collection of images between the `chrono` tags wrapped in a container.

The icons are sequentially set (i.e) the first image you pass will be used as the icon for the first timeline item and so on.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

</chrono>
```

>custom icons also works if you are [rendering custom content](#rendering-custom-content) inside the cards.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.


```sh
<Chrono mode="VERTICAL" items={items}>
<div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide the detailed text in paragraphs Adding small images/icons to the clickable circles on the timeline
1 participant