-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.9 changes #94
1.9 changes #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
This pull request introduces 5 alerts when merging 50715dc into 1cb6417 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 0fbf3a3 into 1cb6417 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
This pull request introduces 1 alert when merging 51e5ad4 into 1cb6417 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
This pull request introduces 1 alert when merging 15f6231 into 1cb6417 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
@@ -335,6 +342,40 @@ The items collection will also work nicely with any custom content that is passe | |||
</Chrono> | |||
``` | |||
|
|||
### 🎭 Custom icons for the Timeline | |||
|
|||
To use custom icons in the timeline, pass in the collection of images between the `chrono` tags wrapped in a container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
### 🎭 Custom icons for the Timeline | ||
|
||
To use custom icons in the timeline, pass in the collection of images between the `chrono` tags wrapped in a container. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
</div> | ||
</chrono> | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
|
||
>custom icons also works if you are [rendering custom content](#rendering-custom-content) inside the cards. | ||
|
||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
>custom icons also works if you are [rendering custom content](#rendering-custom-content) inside the cards. | ||
|
||
```sh | ||
<Chrono mode="VERTICAL" items={items}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
|
||
To use custom icons in the timeline, pass in the collection of images between the `chrono` tags wrapped in a container. | ||
|
||
The icons are sequentially set (i.e) the first image you pass will be used as the icon for the first timeline item and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
</chrono> | ||
``` | ||
|
||
>custom icons also works if you are [rendering custom content](#rendering-custom-content) inside the cards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
|
||
```sh | ||
<Chrono mode="VERTICAL" items={items}> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
Code refactored to pass Top level props to all Functional components via context provider.
cardDetailedText
will now also accept string of arrays. The array is split and placed as a separate text blocks.Support for adding custom icons in the Timeline.