POST received events to status_url in channel status worker #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format junebug's API provides
…em for channel status worker tests
…status-url-in-channel-status-worker
|
Ready for review. |
|
So, the |
|
|
||
| self.assertEqual( | ||
| dict((k, v) for k, v in body.iteritems()), | ||
| body) |
There was a problem hiding this comment.
I'm a little confused as to what this is actually doing. Is it not just comparing body to itself? Should we be comparing it to fields?
There was a problem hiding this comment.
Ya, this looks wrong, should be comparing to fields, thanks, fixing.
|
Ok, ready for review again. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 adds a worker that consumes status events published by a transport. The plan is to change the worker to post received events to a
status_urlgiven to it via its config.