Document nginx plugin #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ | |||
|
|
|||
|
|
|||
| def resource_path(filename): | |||
| return resource_filename('junebug.plugins.nginx', filename) | |||
| return path.join(path.dirname(__file__), filename) | |||
There was a problem hiding this comment.
Building the docs wasn't working with pkg_resources.resource_filename, was getting:
File "/.../junebug/ve/lib/python2.6/site-packages/pkg_resources.py", line 1547, in _extract_resource
timestamp, size = self._get_date_and_size(self.zipinfo[zip_path])
KeyError: 'junebug/plugins/nginx/vhost.template'
Guessing resource_filename wasn't happy with junebug being installed as an egg, but really not too sure.
There was a problem hiding this comment.
We probably also want to remove the import for resource_filename then.
There was a problem hiding this comment.
We could also set `zip_safe=False` in `setup.py`, I think?
There was a problem hiding this comment.
Done. I thought the reason we used pkg_resources.resource_filename was because the __file__ approach wouldn't work in a zip, though.
|
Ready for review. |
|
Ready for re-review. |
|
👍 from me |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.