Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vumi Bridge transport fails to shut down cleanly if it doesn't start up. #1035

Merged

Conversation

hodgestar
Copy link
Contributor

The teardown method needs to not assume that .web_resource is present.

@hodgestar
Copy link
Contributor Author

Ready for review.

yield transport.startWorker()
yield self.setup_transport(transport)
if start:
yield transport.startWorker()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're losing the setup_transport call here. Is that a bad thing?

@rudigiesler
Copy link
Contributor

Just the one question from me. Looks good otherwise.

@hodgestar
Copy link
Contributor Author

The setup_transport method is currently empty and I'm removing it as part of #1036 (sorry, should have mentioned that in a comment straight away).

@rudigiesler
Copy link
Contributor

Ah okay, I see. 👍

@hodgestar hodgestar merged commit 4a17c5c into develop Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants