Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Change styling on answer's page so answers don't overflow/overlap #36

Open
nathenialalleyne opened this issue Nov 23, 2022 · 14 comments
Labels
enhancement New feature or request

Comments

@nathenialalleyne
Copy link

What improvement are you suggesting?

If the answer given is too long, they expand past the answer box and overlap

Why should make this improvement?

Clogs up answer page and looks terrible

How can we make these improvements?

Either add an overflow scroll for the entire box or just for the answer portion
Wrap text to the next line (This can change the box size might be the less ideal solution)
e0c724f373b1d4a5a164ba2d2949f84a

@nathenialalleyne nathenialalleyne added the enhancement New feature or request label Nov 23, 2022
@prakhartiwari0
Copy link
Owner

The biggest answer that possibly can be their is the product of 99,999 x 99,999, which is 9999800001
Here is a brief explanation: https://github.com/prakhartiwari0/Arito/issues/35#issuecomment-1325875153

image

And as you can see, it isn't causing problems (at least on desktop)

@prakhartiwari0
Copy link
Owner

prakhartiwari0 commented Nov 24, 2022

I just checked this on mobile, it is all good there also!

image

If you have any more queries or suggestions, share them and we will discuss them here 😄

@awnnsheca
Copy link

awnnsheca commented Jan 4, 2023

The answers are still overlaping. And it would look better if the answers are centered and the boxes would have had the same size.

Screenshot from 2023-01-04 21-12-53

@awnnsheca
Copy link

Screenshot from 2023-01-04 21-19-56

Something like this would look better :)

@prakhartiwari0
Copy link
Owner

Thanks for your suggestion, you are right in the UI part, but I would like to know what are your thoughts on the alignment of answers.
Doesn't it matter (at least in addition & subtraction)? 🤔

Is there anything else we could do to prevent the overlapping of the answers?

Also,
The largest answer you can get in the VERY HARD level, in Addition, is 19999. You can see below that the alignment is a bit disturbed which we can adjust by reducing the font size or maybe changing some padding, margin or alignment properties.
image

The largest answer you can get in the VERY HARD level in Multiplication is 99990000 (The overall largest answer). As you can see the same problem is happening here, I guess we need to reduce the font size of question numbers and answers.
image

I would love to know what according to you is a good thing to do, does alignment matter or not, and should we make them centered (disturbing the alignment which is not good at present also), or should we change the font-size, padding & margin?

@prakhartiwari0 prakhartiwari0 reopened this Jan 5, 2023
@awnnsheca
Copy link

I think the size of question and answer should be even, so rather than changing the font size we must center the alignment. I tried to center the alignment but the overflowing still persists, for that it would be much better to make the box sizes same.

@prakhartiwari0
Copy link
Owner

Are you saying to make the boxes have fixed width and height? @awnnshikaa

@awnnsheca
Copy link

yes @prakhartiwari0

@prakhartiwari0
Copy link
Owner

yes @prakhartiwari0

But isn't that bad for responsiveness? We already have used the grid layout for the div that contains all the boxes in this CSS https://github.com/prakhartiwari0/Arito/blob/main/css/main.css#L428
and have given min-width and max-width on the boxes here https://github.com/prakhartiwari0/Arito/blob/main/css/main.css#L436

@awnnsheca
Copy link

yes @prakhartiwari0

But isn't that bad for responsiveness? We already have used the grid layout for the div that contains all the boxes in this CSS https://github.com/prakhartiwari0/Arito/blob/main/css/main.css#L428 and have given min-width and max-width on the boxes here https://github.com/prakhartiwari0/Arito/blob/main/css/main.css#L436

keeping the respo

Screenshot from 2023-01-05 13-15-32
nsiveness i've made a few changes. Does this look better?

@awnnsheca
Copy link

Screenshot from 2023-01-05 13-14-41

Screenshot from 2023-01-05 13-16-26

@prakhartiwari0
Copy link
Owner

prakhartiwari0 commented Jan 5, 2023

@awnnshikaa Can you please share a proper screen recording where you demonstrate your modified code and how the website looks in all the different screen sizes (using dev tools)?

@awnnsheca
Copy link

@awnnsheca
Copy link

Screenshot from 2023-01-05 16-05-29

aligned and justified to center as well as increased the minmax grid size to 300px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants