Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching the default method for missing data to -u -s or -u -n -s #4

Closed
RuneBlaze opened this issue Mar 24, 2021 · 3 comments
Closed

Comments

@RuneBlaze
Copy link

RuneBlaze commented Mar 24, 2021

I am following up from a previous correspondence from Dr. Warnow's lab. As shown in your thesis, -u -s is superior to BioNJ*, so it would be great for either -u -s or -u -n -s to be made the default arguments when missing data is seen

(Of course, let me know if this is how you want me to create the issues, or even if you think I should best do some parts of it. I don't know how simple some of these things are, and whether you prefer pull requests filled with potential C++ novice mistakes over modifying on your own. I can also just maintain a fork if you feel like some of the features are out of scope).

@pranjalv123
Copy link
Owner

Thanks for creating this issue. I am happy to make changes if you make issues, and I am also happy to review and accept pull requests. I would prefer it if this was the "canonical" version of ASTRID; while you are certainly free to maintain your own fork, I think it's easier for users if all the features are in one place.

@pranjalv123
Copy link
Owner

Fixed by PR #7

@pranjalv123
Copy link
Owner

(also, I try to respond to pull requests ASAP. For issues it depends when I have time to dig into them.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants