Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprland-git Build issues due to missing tomlplusplus dependency #629

Closed
DarkXero-dev opened this issue Dec 7, 2023 · 23 comments
Closed

Comments

@DarkXero-dev
Copy link

DarkXero-dev commented Dec 7, 2023

You need to include the tomlplusplus package to your install script otherwise there's an issue with Hyprland-git

hyprpm/src/meson.build:7:4: ERROR: Dependency "tomlplusplus" not found, tried pkgconfig and cmake

I am kinda new to Hyprland, trying to install alongside KDE.. Also would be great if you made sure of the following

  • script detect if some of the offered packages are installed. For example I already have ohmyzsh/zsh/powerlevel10k installed as I compile n host them on my own repos. I do not want to override them with -git versions from AUR, at least as a prompt if we want to install or not..
  • Do not force all apps on user, for example I do not need nor use VisualStudio-bin...
  • Script should backup user's current config before applying yours...

Otherwise great job ;)

@DarkXero-dev DarkXero-dev changed the title Hyprland-git / grimblast-git Build issues Hyprland-git Build issues due to missing tomlplusplus dependency Dec 7, 2023
@prasanthrangan
Copy link
Owner

prasanthrangan commented Dec 7, 2023

Hi, thank you so much!

You need to include the tomlplusplus package to your install script otherwise there's an issue with Hyprland-git

oh strange, i don't see tomlplusplus as a dependency mentioned in the hyprland wiki or in aur.. I'm guessing it just a temporary issue with package, I dont have it installed in my system and just tried re-installing hyprland-git and its working now!

  • script detect if some of the offered packages are installed. For example I already have ohmyzsh/zsh/powerlevel10k installed as I compile n host them on my own repos. I do not want to override them with -git versions from AUR, at least as a prompt if we want to install or not..

The script kinda does it, but only check is that specific package is installed (i.e. does does not check if -git or non git version exists), but i like the idea...so I'll try to implement a check for other versions.

  • Do not force all apps on user, for example I do not need nor use VisualStudio-bin...

by default only the essential apps are installed based on this list... as most of these apps have dependency on the themeing script. But users can always update this file to modify the default apps like vccode, firefox etc with their preferred apps.

  • Script should backup user's current config before applying yours...

it does backup your current config file in ~/.config/cfg_backups/* each time you run the script, you can even control what config files to backup/overwrite in this file, where column -

  1. is the overwrite flag Y or N (use N to preserve your changes)
  2. is the backup flag Y or N
  3. config files to restore
  4. dependency check the package for which the config is applied.

@DarkXero-dev
Copy link
Author

DarkXero-dev commented Dec 7, 2023

Ok sorry I did not notice.. I just had failed build until I manually installed it.. So dunno... Remember I am coming from KDE

Also how to set vivaldi as default browser ? Finally am having issue sharing screen on Discord. I do have xwaylandvideobridge installed for it to work on KDE Wayland.. Maybe causing a problem. And how to enable numlock on boot ?

There should also be a restore option for people who want to go back to previous setup, example now if I go back to KDE my setup would be messed up doing manually is a chore. Can't both session configs coexist ?

@prasanthrangan
Copy link
Owner

prasanthrangan commented Dec 7, 2023

Also how to set vivaldi as default browser ? Finally am having issue sharing screen on Discord. I do have xwaylandvideobridge installed for it to work on KDE Wayland.. Maybe causing a problem. And how to enable numlock on boot ?

by default the keybings are set to firefox, but you can change this line in here to vivaldi -

For discord, it can only share xwayland apps by default, but you can try the workaround with xwaylandvideobridge-bin as mentioned in the wiki. You could also try using discord directly from browser, screenshare should work there.

and to enable numlock by default please use numlock_by_default in the input section on hyprland.conf, please refer the input section from the wiki!

Yup, just saw the one about license, I'm on it :)

@DarkXero-dev
Copy link
Author

Yeah I will try. Also please make it it backs up entire config folder as I noticed it currently doesn't. And implement if you can a restore function so people like me with another DE are able to restore them before switching back. Currently had to restore manually from my own backed up files.

I do that via my KDE ricer script as I offer multiple ones.

@Skerse
Copy link
Collaborator

Skerse commented Dec 7, 2023

I really don't think it's necessary to backup your entire config folder, if you want to do that you can very easily do that yourself.

Also what do you mean by implement a restore function? It's existed for a while you can run ./install.sh -r in the ~/Hyprdots/Scripts directory you cloned during installation.

@DarkXero-dev
Copy link
Author

DarkXero-dev commented Dec 7, 2023

Oops sorry didn't see that.. Lol.. I am new to all this.. I am and have been a KDE user for over 5 years.. Never used anything else...

I will try cloning the repo haven't had any luck so far. It's huge and my connection is slow. I had to use a download manager n download zip .. Gonna do a fresh minimal Arch Install on spare SSD see if I can clone repo. Try adding tomlplusplus to install script small pkg to avoid build issues as I had..

Maybe add swaync instead of dunst I heard it is better and more customizable ?

@Skerse
Copy link
Collaborator

Skerse commented Dec 7, 2023

After you clone it, you'll only ever need to run git pull in the Hyprdots directory to get the latest changes from the github without having to download the entire repo every time. This way you can stay up to date by restoring the configs after your pull the latest changes.

Hopefully when #601 get's merged it'll be a lot easier too.

@DarkXero-dev
Copy link
Author

Yeah but initial clone not going through dunno why I keep getting ssl error xD

@DarkXero-dev
Copy link
Author

DarkXero-dev commented Dec 8, 2023

@prasanthrangan

Hey bud, sorry for ping, but I was thinking, do you have a place where we can talk privately ? Discord or something ? I need your help with optimizing your script to make it work better for my needs/setup.. I am no bash expert.. Like work together.. If you have some time.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Dec 8, 2023

hello @DarkXero-dev Have you still not installed the dots?

Are you using meson or make?

@DarkXero-dev
Copy link
Author

hello @DarkXero-dev Have you still not installed the dots?

Are you using meson or make?

Installed just fine just need time to understand how this thing works I have never used WMs before I been using KDE for past 5 years..

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Dec 8, 2023

Hey I uploaded the hyprdots-ctl script on AUR. paru -Sy hyprdots-ctl. You can run hyprdots-ctl man to see available functions. I think I can add a backup script on that and maybe push a PR for a backup script. @Skerse @DarkXero-dev

@DarkXero-dev
Copy link
Author

DarkXero-dev commented Dec 8, 2023

Hey I uploaded the hyprdots-ctl script on AUR. paru -Sy hyprdots-ctl. You can run hyprdots-ctl man to see available functions. I think I can add a backup script on that and maybe push a PR for a backup script. @Skerse @DarkXero-dev

What does this do ? If I may ask ? Also I will be creating my own repo that will have packages needed from AUR saving us trouble from having to build. I am a Distro maintainer after all lool..

Edit :

Repo created lol
https://repos.xerolinux.xyz/xero_hypr/x86_64/

Can be added to pacman.conf

We can work together on making this project better.. If you are willing. HyprDots maintainer + Distro Maintainer. Am not saying we should turn this into a full on Distro, just make sure to make it build less from AUR by having our own repo, for a quicker install, and seamless error free experience. @prasanthrangan ;)

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Dec 8, 2023

What does this do ? If I may ask ?

This was just a script to manage Hyprdots

❯ hyprdots-ctl man
Hyprdots: v0.5-179-gfb9366e
CloneDirectory: /home/khing/Storage/My_Documents/GitHub/KhingDom
Usage: hyprdots-ctl [Function] [Arguments] [Parameters]

  [man]                * Show Manual
  [update]             * Pull Updates From Hyprdots Repository
  [install]            * Installs Hyprdots
                          [fresh]          Fresh installation of Hyprdots
                          [custom]         Custom installation of Apps
  [restore]            * Restore Hyprdots Configurations
                          [defaults]       Restore to Default Configurations of Hyprdots
  [theme]              * Theme Related Actions
                          [set]            Set Theme
                          [next]           Next Theme
                          [prev]           Previous Theme
                          [select]         Theme Selector
                          [patch]          Patch A Theme from different repository.
  [wallpaper]          * Wallpaper related Actions
                          [set]            Set /Path/to/Wallpaper as Wallpaper
                          [next]           Next Wallppaer
                          [prev]           Previous Wallpaper
                          [select]         Wallpaper Selector
  [sddm]               * Sddm Things
                          [set]            Set active Wallpaper to Sddm Lockscreen
  [wallbash]           * Wallbash
                          [toggle]         Toggle Wall bash On/Off
  [waybar]             * Waybar related Things
                          [control]        Edit waybar Control File.
  [code]               * Modify Vscode Extensions
                          [select]         Selector for default Theme presets
  [cache]              * Cache
                          [reload]         Reload Caches if you have new wallpapers.
                          [rebuild]        Force rebuild cache
                          [add]            Cache custom /path/to/wallpaper/*
                          
          

@DarkXero-dev
Copy link
Author

@kRHYME7 Nice ! Added to my Hypr_repo ;)

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Dec 9, 2023

I guess, libtomlplusplus is required for the hypr plugin manager.

https://wiki.hyprland.org/hyprland-wiki/pages/Plugins/Using-Plugins/#hyprpm

@Skerse
Copy link
Collaborator

Skerse commented Dec 9, 2023

Oh wow i didn't realize i was talking to the xerolinux dev, nice to see you here! I believe everyone here would be happy if you wanted to help make this project better.

A separate repo for pre-compiled aur packages during installation would definitely be nice, especially since it takes me around 40-50 minutes from running ./install.sh to it finishing.

Creating an entire distro for hyprdots is a lot harder because of the way it's been built. I think however for right now, doing archinstall with minimal desktop, then with the introduction of hyprdots-ctl, it's really not that difficult to install and maintain hyprdots updates anymore.

I'd love to hear @prasanthrangan opinions on this, and this discussion should definitely continue on a discussion post instead of this issue thread so if you'd like to create one @DarkXero-dev please do!

@DarkXero-dev
Copy link
Author

DarkXero-dev commented Dec 9, 2023

Oh no never a Distro. I tried to add more "flavors" and failed twice. No time as am alone doing this. People come n help which is greatly appreciated, but they also always leave me hanging by a thread. It also took me 6 hours from first running ./install.sh to login coz my connection be too slow, that's what prompted me to build packages.

Hopefully @prasanthrangan will see it n we can make this script better.

Edit 👍🏻
Discussion created ==> Here

@prasanthrangan
Copy link
Owner

prasanthrangan commented Dec 9, 2023

whoaa @DarkXero-dev , you are the developer for XeroLinux... nice to see you in here! I love your KDE customization in your distro, it looks clean and consistent :) keep up the good work!

We can work together on making this project better.. If you are willing. HyprDots maintainer + Distro Maintainer. Am not saying we should turn this into a full on Distro, just make sure to make it build less from AUR by having our own repo, for a quicker install, and seamless error free experience. @prasanthrangan ;)

ya this repo just has the config files/scripts, so it is easier for me to maintain this, but it takes a lot of time and effort to make this a distro, so i dont think i'll have enough time to do so :(
regarding maintaining our own package repo, no idea if it is simple to maintain it, mainly because hyprland is VERY VERY active in development and its not expected to be stable.

Creating an entire distro for hyprdots is a lot harder because of the way it's been built. I think however for right now, doing archinstall with minimal desktop, then with the introduction of hyprdots-ctl, it's really not that difficult to install and maintain hyprdots updates anymore.

I'd love to hear @prasanthrangan opinions on this, and this discussion should definitely continue on a discussion post instead of this issue thread so if you'd like to create one @DarkXero-dev please do!

yup, i agree @Skerse making this a distro requires a lot of time and effort to maintain... But ya @DarkXero-dev feel free to fork this and maintain the packages based your repo, I can definitely help you with improving/updating the script and configure pacman.conf

@DarkXero-dev
Copy link
Author

@prasanthrangan

Hehe thanks bud.. Just a bit of info, I do not and will not use WMs they do not fit my workflow. However that doesn't mean I cannot help other projects thrive when I can.

That being said all I meant to say is, not fork the project coz I wouldn't know where to start since it's not my thing. I was thinking of sharing ideas, as I did
==> Here.

Also let me worry about Repo, we can work on it together, you tell me what needs to be added packages wise leaving rest as it is, just so script doesn't have to build everything from AUR making it takes ages, with potential failures. I maintain 5 repos as it is it's fun for me. We merge heads..

Let me know what you think of my ideas on Discussion thread.. I am aware of how Vaxry works he was my guest on my show. Video never made the cut but we talked for hours..

@prasanthrangan
Copy link
Owner

Hey bud, sorry for ping, but I was thinking, do you have a place where we can talk privately ? Discord or something ? I need your help with optimizing your script to make it work better for my needs/setup.. I am no bash expert.. Like work together.. If you have some time.

sure, my discord username is nagnar. but i rarely use discord so please expect a delay :)

@DarkXero-dev
Copy link
Author

DarkXero-dev commented Dec 9, 2023

@prasanthrangan Will add you no rush .. Check previous message+Discussion.. You also keep forgetting license lol

Edit : Seems you are not accepting friend request hmm.. I am TechXero on there

@prasanthrangan
Copy link
Owner

yup, just added! and saw the discussions page. I'll close this so we can continue in #634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants