-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open dialog creates scroll bar #30
Comments
Additionally, the dialog does not close when clicking on any of the buttons, just by clicking outside of it. I have AlpineJS as a |
I'll fix the scroll bar bug 👍 Can you share a minimal reproduction repo for the close event not working? |
@praveenjuge Done.
|
This also seems to be the case for another dynamic component, the drawer @praveenjuge . If you look at the |
Thanks, I'll take a look |
Thank you, I hope it can be resolved. I tried cloning this repo: #5 that did not use AlpineJS, and the dialog worked perfectly. However, since then the dialog has been changed and no longer works - this may be useful information to you. |
@praveenjuge Fixed in this PR: #31 Although the dialog creating scrollbar to the right still happens. |
Hey, I have fixed the issue in the latest commit. You can check if it's working here: https://codepen.io/praveenjuge/pen/KKNdavv I'll tag a release soon. Thanks for raising this issue! |
Works great, thanks for fixing and making Kutty! |
Fixed in release 0.5.0 |
For a page that does not have a scroll bar, everything gets shifted slightly to the left when the dialog opens, as a scrollbar is created.
Before
After
Note the white bar on the far right.
Is there any way to prevent this behavior?
The text was updated successfully, but these errors were encountered: