Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing for reader and writer #51

Closed
EronWright opened this issue Sep 8, 2017 · 1 comment
Closed

Unit testing for reader and writer #51

EronWright opened this issue Sep 8, 2017 · 1 comment
Milestone

Comments

@EronWright
Copy link
Contributor

EronWright commented Sep 8, 2017

Problem description
The existing tests do not provide adequate coverage because they're unable to simulate a wide variety of edge cases. For example, the writer has logic for write failures and async writes that isn't exercised.

Suggestions for an improvement
Develop a new set of tests that use a mock Pravega client and the Flink-provided operator test harness. See io.pravega.connectors.flink.EventTimeOrderingOperatorTest for an example.

Consider moving those tests that rely on an embedded Pravega server to intTest.

@EronWright
Copy link
Contributor Author

All readers and writers have unit tests now, except for FlinkPravegaInputFormat which is covered by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant