New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3266: Ensure bookkeeper.bkAckQuorumSize is 3 for BookieFailover test. #3267
Conversation
Signed-off-by: Sandeep <sandeep.shridhar@emc.com>
Codecov Report
@@ Coverage Diff @@
## master #3267 +/- ##
============================================
+ Coverage 78.86% 78.86% +<.01%
- Complexity 8012 8032 +20
============================================
Files 609 609
Lines 31476 31501 +25
Branches 3041 3046 +5
============================================
+ Hits 24822 24844 +22
- Misses 4858 4867 +9
+ Partials 1796 1790 -6
Continue to review full report at Codecov.
|
Signed-off-by: Sandeep <sandeep.shridhar@emc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These changes enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* master: (31 commits) Issue 3279: Client is performing blocking operations inside Netty Event Loop (pravega#3280) Issue 3200: Document Review: wire-protocol.md (pravega#3201) Issue 2933: (SegmentStore) testEndToEndWithFencing fixes (pravega#3294) Issue pravega#2768: Rename PravegaCredsWrapper class and its member variable (pravega#3302) Issue pravega#3299: Reduce dependencies in client (pravega#3300) Issue 2895: Wire Protocol implementation for TableStore (pravega#3283) Issue-3239: Make DYNAMIC_LOGGER non-static (pravega#3293) Issue 2956: (SegmentStore) TableSegment.deleteIfEmpty (pravega#3263) Issue pravega#3289: Use compile-time dependencies where possible (pravega#3290) Issue 3223: RetentionTest failure (pravega#3272) Issue 2001: Make a defensive copy of streamCut's position map (pravega#3281) Issue 3287: Exclude "passwd" extensions from rat. (pravega#3288) Issue 3285: Changed image pull policy. (pravega#3286) Issue 3266: Ensure bookkeeper.bkAckQuorumSize is 3 for BookieFailover test. (pravega#3267) Issue 3264: Return a SegmentHandle from Storage create method. (pravega#3276) Issue 3086: Controller Diagrams(new) included (pravega#3097) Issue 2570: Update segment metrics when a transaction merge happens (pravega#3239) Issue 3149: (SegmentStore) Pinned Segments (pravega#3215) Issue 3269: Fix invalid initialization order in AbstractScaleTests. (pravega#3270) Issue 3148: (Segment Store) Segment Metadata Store (pravega#3206) ...
(This has to be merged once the pravega-operator issue has been fixed).
Change log description
Ensure
bookkeeper.bkAckQuorumSize
is configured as 3 during system tests.Purpose of the change
Fixes #3266
What the code does
The bookieFailover test expects bkAckQuorumSize to be 3.
How to verify it
The BookieFailoverTest should pass once pravega/pravega-operator#116 is resolved.
Update : verified that the bookieFailover test works fine with the modified version of pravega-operator.