Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3285: Always pull images in k8 system test framework #3286

Merged

Conversation

RaulGracia
Copy link
Contributor

Change log description
Set image pull policy to "Always" in k8 system test framework.

Purpose of the change
Fixes #3285.

What the code does
Sets the default IMAGE_PULL_POLICY to Always in k8 system test framework. Otherwise, we could end up using an old (cached) image version unexpectedly.

How to verify it
System tests should pass and use the latest version of the images available.

Signed-off-by: Raúl Gracia <raul.gracia@emc.com>
Copy link
Contributor

@adrianmo adrianmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaulGracia
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #3286 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3286      +/-   ##
============================================
- Coverage     78.85%   78.83%   -0.02%     
+ Complexity     8026     8020       -6     
============================================
  Files           609      609              
  Lines         31497    31497              
  Branches       3046     3046              
============================================
- Hits          24836    24831       -5     
- Misses         4867     4869       +2     
- Partials       1794     1797       +3
Impacted Files Coverage Δ Complexity Δ
...server/attributes/ContainerAttributeIndexImpl.java 79.71% <0%> (-10.15%) 17% <0%> (-2%)
...erver/logs/operations/CheckpointOperationBase.java 90.9% <0%> (-4.55%) 4% <0%> (-1%)
...egmentstore/server/containers/MetadataCleaner.java 86.53% <0%> (-3.85%) 14% <0%> (-2%)
...a/segmentstore/server/logs/OperationProcessor.java 84.75% <0%> (-1.49%) 38% <0%> (-3%)
...a/io/pravega/segmentstore/server/CacheManager.java 79.72% <0%> (-1.36%) 35% <0%> (-1%)
...main/java/io/pravega/storage/hdfs/HDFSStorage.java 73.38% <0%> (-0.72%) 51% <0%> (ø)
...o/pravega/segmentstore/server/logs/DurableLog.java 89.26% <0%> (-0.49%) 67% <0%> (-1%)
.../segmentstore/server/writer/SegmentAggregator.java 78.5% <0%> (-0.28%) 237% <0%> (-1%)
...vega/segmentstore/server/writer/StorageWriter.java 88.93% <0%> (+0.44%) 62% <0%> (+1%) ⬆️
...ver/containers/StreamSegmentContainerMetadata.java 97.41% <0%> (+0.64%) 52% <0%> (+1%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379dfed...6b2eca2. Read the comment docs.

Copy link
Contributor

@shrids shrids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@shrids shrids merged commit 4a02461 into pravega:master Jan 16, 2019
adrianmo added a commit to adrianmo/pravega that referenced this pull request Jan 23, 2019
* master: (31 commits)
  Issue 3279: Client is performing blocking operations inside Netty Event Loop (pravega#3280)
  Issue 3200: Document Review: wire-protocol.md (pravega#3201)
  Issue 2933: (SegmentStore) testEndToEndWithFencing fixes (pravega#3294)
  Issue pravega#2768: Rename PravegaCredsWrapper class and its member variable (pravega#3302)
  Issue pravega#3299: Reduce dependencies in client (pravega#3300)
  Issue 2895: Wire Protocol implementation for TableStore (pravega#3283)
  Issue-3239: Make DYNAMIC_LOGGER non-static (pravega#3293)
  Issue 2956: (SegmentStore) TableSegment.deleteIfEmpty (pravega#3263)
  Issue pravega#3289: Use compile-time dependencies where possible (pravega#3290)
  Issue 3223: RetentionTest failure (pravega#3272)
  Issue 2001: Make a defensive copy of streamCut's position map (pravega#3281)
  Issue 3287: Exclude "passwd" extensions from rat. (pravega#3288)
  Issue 3285: Changed image pull policy. (pravega#3286)
  Issue 3266: Ensure bookkeeper.bkAckQuorumSize is 3 for BookieFailover test. (pravega#3267)
  Issue 3264: Return a SegmentHandle from Storage create method. (pravega#3276)
  Issue 3086: Controller Diagrams(new) included (pravega#3097)
  Issue 2570: Update segment metrics when a transaction merge happens (pravega#3239)
  Issue 3149: (SegmentStore) Pinned Segments (pravega#3215)
  Issue 3269: Fix invalid initialization order in AbstractScaleTests. (pravega#3270)
  Issue 3148: (Segment Store) Segment Metadata Store (pravega#3206)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants