Issue 3264: Return a SegmentHandle from Storage create method. #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Codecov Report
@@ Coverage Diff @@
## master #3276 +/- ##
============================================
+ Coverage 78.85% 78.95% +0.09%
- Complexity 8031 8055 +24
============================================
Files 609 609
Lines 31501 31610 +109
Branches 3046 3085 +39
============================================
+ Hits 24841 24957 +116
- Misses 4865 4866 +1
+ Partials 1795 1787 -8
Continue to review full report at Codecov.
|
…eate. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
andreipaduroiu
requested changes
Jan 14, 2019
...rver/src/main/java/io/pravega/segmentstore/server/attributes/SegmentAttributeBTreeIndex.java
Outdated
Show resolved
Hide resolved
segmentstore/storage/src/main/java/io/pravega/segmentstore/storage/rolling/RollingStorage.java
Outdated
Show resolved
Hide resolved
…ge.create. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
andreipaduroiu
approved these changes
Jan 15, 2019
adrianmo
added a commit
to adrianmo/pravega
that referenced
this pull request
Jan 23, 2019
* master: (31 commits) Issue 3279: Client is performing blocking operations inside Netty Event Loop (pravega#3280) Issue 3200: Document Review: wire-protocol.md (pravega#3201) Issue 2933: (SegmentStore) testEndToEndWithFencing fixes (pravega#3294) Issue pravega#2768: Rename PravegaCredsWrapper class and its member variable (pravega#3302) Issue pravega#3299: Reduce dependencies in client (pravega#3300) Issue 2895: Wire Protocol implementation for TableStore (pravega#3283) Issue-3239: Make DYNAMIC_LOGGER non-static (pravega#3293) Issue 2956: (SegmentStore) TableSegment.deleteIfEmpty (pravega#3263) Issue pravega#3289: Use compile-time dependencies where possible (pravega#3290) Issue 3223: RetentionTest failure (pravega#3272) Issue 2001: Make a defensive copy of streamCut's position map (pravega#3281) Issue 3287: Exclude "passwd" extensions from rat. (pravega#3288) Issue 3285: Changed image pull policy. (pravega#3286) Issue 3266: Ensure bookkeeper.bkAckQuorumSize is 3 for BookieFailover test. (pravega#3267) Issue 3264: Return a SegmentHandle from Storage create method. (pravega#3276) Issue 3086: Controller Diagrams(new) included (pravega#3097) Issue 2570: Update segment metrics when a transaction merge happens (pravega#3239) Issue 3149: (SegmentStore) Pinned Segments (pravega#3215) Issue 3269: Fix invalid initialization order in AbstractScaleTests. (pravega#3270) Issue 3148: (Segment Store) Segment Metadata Store (pravega#3206) ...
sachin-j-joshi
deleted the
issue-3264-storage-create-should-return-segmenthandle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sachin Joshi sachin.joshi@emc.com
Change log description
Segment create returns a read-write SegmentHandle . This eliminates the redundant fencing/ checks.
Purpose of the change
Fixes #3264
What the code does
All SyncStorage implementations now return read-write SegmentHandle (and avoid redundant checks/file access)
How to verify it
All unit tests and integration tests should pass.
Some improvement in performance.