Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit error handling for JSON parsing errors #30

Closed
justingaylor opened this issue Oct 14, 2013 · 1 comment
Closed

Revisit error handling for JSON parsing errors #30

justingaylor opened this issue Oct 14, 2013 · 1 comment
Milestone

Comments

@justingaylor
Copy link
Contributor

It's important to know what failed to parse in JSON. However, including that information in the exception message might be too long (for large JSON). Might be better to log this information.

Also, may be important to consider not logging sensitive data, such as SSH keys material.

Per discussion here: https://github.com/rightscale/attributor/pull/26/files#r6810501

@careo careo modified the milestone: v3.0 Sep 15, 2014
@gampleman
Copy link
Contributor

This is a duplicate of https://github.com/rightscale/attributor/issues/29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants