Add note about mypy in the isolated virtualenv #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Aug 24, 2020
| @@ -37,3 +37,6 @@ dependencies) you may also find it useful to add the typed dependencies to | |||
| - id: mypy | |||
| additional_dependencies: [tokenize-rt==3.2.0] | |||
| ``` | |||
|
|
|||
| Note that if you don't specify additional dependencies, because of the isolated | |||
| virtualenv you might get different output when running `mypy` into your own virtualenv. | |||
There was a problem hiding this comment.
isn't this the same as what lines 31-33 say?
There was a problem hiding this comment.
Yeah you are right, my fault for not giving that enough importance! 👍
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pre-commit/pre-commit#1580