Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Support for PureComponent #139

Closed
adriantoine opened this issue Aug 4, 2016 · 4 comments
Closed

Support for PureComponent #139

adriantoine opened this issue Aug 4, 2016 · 4 comments
Milestone

Comments

@adriantoine
Copy link

adriantoine commented Aug 4, 2016

Hi,

In v15.3.0, React has introduced PureComponent which is like Component with react-addons-pure-render-mixin integrated.

I don't think preact-compat supports it at the moment, is it planned?

Thanks!

@developit
Copy link
Member

Yup! Support is definitely planned, we are just working out whether it will be a feature of preact-compat or something built into preact itself:

preactjs/preact#163

@adriantoine
Copy link
Author

Awesome!

@rfreitas
Copy link

rfreitas commented Oct 4, 2016

Does the documentation state this difference in implementation? I just spent a day debugging an issue which I think it's related to this.

@developit
Copy link
Member

developit commented Oct 4, 2016

No, sorry - it does mention the React version somewhere as being 15.1.0, which didn't have PureComponent. That said, your comment prompted me to add support for it, so if you update preact-compat, it's there. The new version is 3.6.0.

@developit developit added this to the 3.6.0 milestone Oct 4, 2016
szafranek added a commit to fabric-design/components that referenced this issue Aug 29, 2017
…ed by preact-compat

As a bonus, this fixes the warning generated when running tests:
"export 'PureComponent' (imported as '_React_') was not found in 'react'
preactjs/preact-compat#139
szafranek added a commit to fabric-design/components that referenced this issue Sep 5, 2017
…ed by preact-compat

As a bonus, this fixes the warning generated when running tests:
"export 'PureComponent' (imported as '_React_') was not found in 'react'
preactjs/preact-compat#139
szafranek added a commit to fabric-design/components that referenced this issue Sep 12, 2017
…ed by preact-compat

As a bonus, this fixes the warning generated when running tests:
"export 'PureComponent' (imported as '_React_') was not found in 'react'
preactjs/preact-compat#139
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants