Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Breaks onDoubleClick mouse event. #264

Closed
rokoroku opened this issue Dec 28, 2016 · 3 comments
Closed

Breaks onDoubleClick mouse event. #264

rokoroku opened this issue Dec 28, 2016 · 3 comments

Comments

@rokoroku
Copy link
Contributor

rokoroku commented Dec 28, 2016

Using preact-compat as an alias for react and react-dom seems to break some mouse events.

for example, onChange inside of <input type="checkbox"> fired twice, and onDoubleClick inside <label> are not fired.

Issue can be reproduced with this sample: link

@developit
Copy link
Member

The event name is actually onDblClick. Are you able to verify that onDoubleClick works in React? If so we can just alias that event name.

As for the onChange event, I believe we already merged a PR that fixes the doubling issue, but it hasn't yet been released.

@rokoroku
Copy link
Contributor Author

rokoroku commented Dec 29, 2016

@developit Only onDoubleClick is visible in the document, and it also works. See docs#mouse-events.

By the way, good to hear fixing another issue 👍

@developit
Copy link
Member

Alright! Open to PRs, or I'll try to get this done when I'm back to things next week!

rokoroku added a commit to rokoroku/preact-compat that referenced this issue Dec 31, 2016
@rokoroku rokoroku closed this as completed Jan 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants