This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Make the Children API compatible with React #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some differences to the following methods that caused Preact to act differently than React: - Children.map - Children.forEach - Children.count
developit
reviewed
Nov 11, 2016
| children = Children.toArray(children); | ||
| if (ctx && ctx!==children) fn = fn.bind(ctx); | ||
| children.forEach(fn); | ||
| }, | ||
| count(children) { | ||
| children = Children.toArray(children); | ||
| return children.length; | ||
| let count = 0; |
There was a problem hiding this comment.
Can we skip the iteration here and just do something like this?
return children && children.length || 0;There was a problem hiding this comment.
Oh, of course! Nice catch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some differences to the following methods
that caused Preact to act differently than React: