This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Merge mixin return values #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that getDefaultProps works
Stuk
force-pushed
the
merge-mixin-return
branch
from
8a28f39
to
115d82e
Compare
|
I've rebased on top of master, and improved the changes |
|
@developit is this still under review? We use a lot of this state composition with mixins in Electrode, would love to see this merged and would be happy to help review. |
|
Top of my list. Does it look good to you? I don't use mixins so I'm just basing it off the public React API. |
|
@developit it looks solid to me, and if the tests pass I think it's probably good to go. |
|
Alrighty! It bumps the file size up a little bit, but I'm hoping to deal with that shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239.
Let me know if anything isn't clear or is just plain wrong. Happy to make changes :)