This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Delete onChange attribute when aliased #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent the change event from firing twice when clicking on a checkbox, see here: preactjs/preact#358
|
Awesome! Thanks for this! |
|
Hi, sorry to bother you on a closed issue, but I think the change you introduced broke the input[type="radio"]: looking at the code it seems like you are deleting the onChange for any input type not checkbox, in favour of an onInput, but the radio wouldn't work with it. Sorry if I'm wrong, I've been trying to debug this issue since a while in my app and I'm a little tired :D |
cedmax
added a commit
to cedmax/preact-compat
that referenced
this pull request
Jan 19, 2017
As suggested in the comment to the merged PR (ref: preactjs#247) the event normalisation has broken the support for onChange on radio buttons. This is a potential fix
|
oooh, very good catch @cedmax! Are you able to open a new issue for that? We'll get it fixed right away. |
|
sure thing, I'm on my way to do it |
This was referenced Jan 19, 2017
developit
pushed a commit
that referenced
this pull request
Jan 19, 2017
* Fix for the radio button not working with onChange As suggested in the comment to the merged PR (ref: #247) the event normalisation has broken the support for onChange on radio buttons. This is a potential fix * Using match on attribute type to identify checkbox and radio inputs * added back the lowercase enforcing * moved to test to ensure empty strings work too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the change event from firing twice when clicking on a checkbox, addressing this issue: preactjs/preact#358