Click on Checkbox Fires Twice

[pahund]

I have a checkbox with an onchange handler like this:

When I click the checkbox, nothing happens. I think this is because the click triggers both a click and onchange event, one ticks the checkbox, the other unchecks it again (using Redux to handle the event).

I'm using Preact 6.3.0 with Preact-Compat 3.7.1.

Is this a bug, or do I have to change my implementation when using Preact instead of React? It works without a problem with Facebook's React.

[developit]

I'd need to know roughly what onChange is doing in order to diagnose. Click/change normalization is in preact-compat (here), so this issue might be better-suited to that repo.

I think you might be right though - it seems like the above linked normalization never removes the old onchange prop, so perhaps that's causing it to fire twice.

[pahund]

Should I move the issue to preact-compat?

In my app, when you click on a checkbox, a redux action is dispatched, which causes the state of the app to be changed, thus setting the checked prop of my Checkbox component.

[pahund]

Using onClick instead of onChange fixed the problem for me:

[developit]

Perfect, sounds like we just need to have preact-compat delete the onChange prop when it aliases it as onClick. Thanks for testing that out!

[pahund]

Glad to help, keep up the good work!

[developit]

This has been fixed in preact-compat, and will be released shortly.