This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Allow children in the props argument of cloneElement #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloneElement - if children are provided in the second
argument of cloneElement they are ignored.
`cloneElement(component, { children })` will now properly apply children to `component`
fixes preactjs#316
tkh44
commented
Mar 7, 2017
| // Only provide the 3rd argument if needed. | ||
| // Arguments 3+ overwrite element.children in preactCloneElement | ||
| let cloneArgs = [node, props]; | ||
| if (children && children.length) { |
There was a problem hiding this comment.
@developit this is the one part I'm not 100% certain on. I'm not sure if I should check children.length here.
There was a problem hiding this comment.
I actually wonder (was going to modify and run the tests) if the block on L313 can get dropped? preactCloneElement() will look for props.children if its arity is <=2 and it seems like we're passing it props.children in that case.
There was a problem hiding this comment.
You cannot drop the if statement. children will always be an array because of the spread operator. If you provide an empty array to preactCloneElement it will result in the original children being overwritten with [] (nothing).
Use push instead of concat - Cleaner - Smaller size
developit
approved these changes
Mar 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloneElement - if children are provided in the second
argument of cloneElement they are ignored.
cloneElement(component, { children })will now properly apply children tocomponentfixes #316