Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

IE11 seems to define Symbol but without the method 'for' #423

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

kozak
Copy link
Contributor

@kozak kozak commented Sep 14, 2017

Fixes:
"Object does not support the method for" error in IE11.

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@developit developit merged commit 1a88d10 into preactjs:master Sep 21, 2017
@kozak
Copy link
Contributor Author

kozak commented Oct 4, 2017

@developit If you don't mind, could you release a version with this patch included? Thank you!

@vvo
Copy link

vvo commented Oct 13, 2017

There might be something else in here because Symbol is not at all supported in IE11: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol#Browser_compatibility

We have been facing the same issue and it might just come from a polyfill that defines only part of Symbol.

@vvo
Copy link

vvo commented Oct 19, 2017

Quick update on this, for reference, IE11 does not have window.Symbol at all. But anyone using babel-polyfill (https://babeljs.io/docs/usage/polyfill/), will have a sub-complete Symbol being defined, without Symbol.for.

So this current PR really fixes preact-compat compatibility with babel-polyfill, not IE11. It's a side effect that it fixes IE11.

Still, it's a valid fix.

Any way we can get a release of preact-compat @developit, pleeeease? :) npm run release?

@kozak
Copy link
Contributor Author

kozak commented Oct 19, 2017 via email

laysent added a commit to laysent/preact-compat that referenced this pull request Oct 21, 2017
@developit
Copy link
Member

Yup, I'll get something out today or tomorrow. Sorry for the slows!

laysent added a commit to laysent/preact-compat that referenced this pull request Jan 30, 2018
Haroenv added a commit to algolia/algoliasearch-extensions-bundle that referenced this pull request Aug 2, 2018
1. make sure `preact-compat` is at a version which supports IE11

fixes https://github.com/algolia/algoliasearch-magento-2/issues/535

See for more information also preactjs/preact-compat#423, which is the original fix of the bug

2. make sure there's no duplicate dependency versions by using Yarn  resolutions

NOTE: you can only use Yarn now to build, not npm.
Haroenv added a commit to algolia/algoliasearch-extensions-bundle that referenced this pull request Aug 2, 2018
1. make sure `preact-compat` is at a version which supports IE11

fixes https://github.com/algolia/algoliasearch-magento-2/issues/535

See for more information also preactjs/preact-compat#423, which is the original fix of the bug

2. make sure there's no duplicate dependency versions by using Yarn  resolutions

NOTE: you can only use Yarn now to build, not npm.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants