This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Add createContext #529
Merged
Add createContext #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developit
approved these changes
Jun 12, 2019
The rationale behind marking dependencies as external is because they're likely to already be installe in the client projects and flat bundling them is unnecessary extra code. However preact-context is very new and people are less likely to be using it so we'll bundle it.
|
@developit any chance we could ship this soonish? 😬 otherwise I've gotta disable the preact tests in jest-styled-components when I ship the next version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically just consumes and re-exports https://github.com/valotas/preact-context so people don't have to do extra steps.