Perf improvements v2 #278
Merged
Perf improvements v2 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a187f66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marvinhagemeister
approved these changes
Feb 24, 2023
Merged
There was a problem hiding this comment.
@JoviDeCroock Sorry I'm a little late to the game 😅 I did have a couple of quick questions when you get a chance
| : ';'); | ||
| let suffix = ';'; | ||
| if (SUFFIX_CACHE[name]) { | ||
| suffix = 'px'; |
There was a problem hiding this comment.
does this need to be 'px;' (note the semicolon after the px)?
| ? 'px;' | ||
| : ';'); | ||
| let suffix = ';'; | ||
| if (SUFFIX_CACHE[name]) { |
There was a problem hiding this comment.
Do we need to check if typeof val === 'number' here as well? If the first call to render is <div style={{ padding: 8 }} /> but the second is <div style={{ padding: '8px' }} />, will it still add the 'px'?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.