Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preventBubbling is optional #337

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apostololeg
Copy link

Hi there!
I moved from react to preact and detect that my autoClose-feature in Popup was broken.
I discover that preact-router are preventing event bubbling when clicking on <Link/>.
I wonder to ask you – what prompted you to do this❓🙂

Anyway, I made this PR in case if you(like me) will decide to move this feature from default to optional.

@developit
Copy link
Member

Hi @apostololeg! I think we could actually just remove the bubbling prevention. preact-router is only replacing the default behavior, so it should really only be preventing default, not bubbling.

Want to update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants