Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tutorial): update relative URL to preact-cli #453

Merged
merged 1 commit into from Oct 10, 2019

Conversation

d2s
Copy link
Contributor

@d2s d2s commented Oct 9, 2019

  • Update relative URL to preact-cli page
    • URL was missing / character from the beginning, causing missing page error

- Update relative URL to preact-cli page
  - URL was missing `/` character from the beginning, causing missing page error
@size-plugin
Copy link
Contributor

size-plugin bot commented Oct 9, 2019

Size report for the changes in this PR:

size-plugin-ssr Overall size: 208 kB

    editor.chunk.*****.js ⏤  65.9 kB
     emoji.chunk.*****.js ⏤  8.83 kB
    runner.chunk.*****.js ⏤  5.86 kB
            ssr-bundle.js ⏤  28.6 kB
   editor.chunk.7a736.css ⏤  3.17 kB
 markdown.c3d26.worker.js ⏤  9.56 kB
    prism.e82c3.worker.js ⏤  7.24 kB
     repl.51501.worker.js ⏤  68.5 kB
     ssr-bundle.ac3c8.css ⏤  10.9 kB

commit: 0a4ae78

@size-plugin
Copy link
Contributor

size-plugin bot commented Oct 9, 2019

Size report for the changes in this PR:

size-plugin-browser Overall size: 395 kB

                 sw-esm.js ⏤  682 B
                     sw.js ⏤  678 B
  emoji.chunk.91398.esm.js ⏤  8.85 kB
    polyfills.6a525.esm.js ⏤  2.13 kB
      emoji.chunk.1ed91.js ⏤  8.85 kB
        polyfills.3233a.js ⏤  2.12 kB
    editor.chunk.7a736.css ⏤  2.15 kB
 editor.chunk.fa6b3.esm.js ⏤  66.3 kB
         5.chunk.bc319.css ⏤  1.47 kB
      5.chunk.95a73.esm.js ⏤  3.39 kB
     editor.chunk.e0251.js ⏤  66.4 kB
          5.chunk.b2018.js ⏤  3.45 kB
          bundle.c6f3d.css ⏤  9.11 kB
     prism.d329b.worker.js ⏤  7.32 kB
  markdown.6af7e.worker.js ⏤  9.66 kB
      repl.bfeb7.worker.js ⏤  66.7 kB
       bundle.6ee5f.esm.js ⏤  22.9 kB
 runner.chunk.097ea.esm.js ⏤  5.79 kB
  markdown.d9ce1.worker.js ⏤  9.66 kB
      repl.6e676.worker.js ⏤  68.1 kB
           bundle.31633.js ⏤  23.2 kB
     runner.chunk.50868.js ⏤  5.83 kB

commit: 0a4ae78

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Thank you so much for your PR 🎉

@marvinhagemeister marvinhagemeister merged commit 5ba1747 into preactjs:master Oct 10, 2019
@d2s d2s deleted the patch-1 branch October 10, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants