Fix UNSAFE_* lifecycles being overwritten #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
requested review from
cristianbote,
developit and
JoviDeCroock
marvinhagemeister
force-pushed
the
unsafe-descr
branch
from
46c8f9b
to
9e4dc25
Compare
JoviDeCroock
approved these changes
Sep 24, 2019
|
Are we okay with merging this and doing the optimisation as a separate PR? |
This was caused by transpilers overwriting our patched property.
marvinhagemeister
force-pushed
the
unsafe-descr
branch
from
aa9aec5
to
0bd9f56
Compare
This was referenced Oct 26, 2019
developit
added a commit
that referenced
this pull request
Sep 4, 2020
JoviDeCroock
pushed a commit
that referenced
this pull request
Sep 13, 2020
* Optimizations for compat * Use native DOM Event methods instead of patching Event. * Found a smaller+faster fix for #1941 / #1946 🎉 * Fix test failures (forgot to apply normalizedProps) * Fix className aliasing order. Note: this removes the forced priority bump from `className` and instead uses object property order. * Fix <select multiple> array value * Fix onChange normalization * Fix lifecycle assignment in loose mode transpiled classes * Select class/className purely based on property order * defaultValue fixes * Normalize onChange to onInput for <input type=range>, but not in IE11 which fires continuous change events for range inputs. * size tweaks * Optimization + clarifying comments for defaultValue * Optimizations for <select multiple> array value * little size optimization for render() clearing * Backport golf from v10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by transpilers overwriting our patched property when inheritance was in play. It's based on the assumption that having both the prefixed
UNSAFE_*and the unprefixed lifecycle hook is invalid.Fixes #1941
Adds
+29 Bto compat.