Add dom.data during hydration to avoid redundantly adding text… #2238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the dom not being available as a node
diffChildren
will double add this text if we don't set the dom.dataI have been looking at solving it in
diffChildren
but the problem persists itself like this:So we effectively come in at the first newChild and diff it with oldDom, next up we have no oldDom and we just append it to the text node.
A potential perf improvement would be to check if the
parent.innerHTML === props
this would allow us to skip childDiffing for that text node (if it does not contain any dom nodes).Fixes #2237