Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydration suspend tests #2755

Merged
merged 11 commits into from Nov 11, 2020
Merged

Hydration suspend tests #2755

merged 11 commits into from Nov 11, 2020

Conversation

andrewiggins
Copy link
Member

Start at some tests for hydration suspend and resume

@github-actions
Copy link

github-actions bot commented Sep 15, 2020

Size Change: -9 B (0%)

Total Size: 41.7 kB

Filename Size Change
compat/dist/compat.js 3.18 kB -5 B (0%)
compat/dist/compat.module.js 3.19 kB +2 B (0%)
compat/dist/compat.umd.js 3.23 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 184 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Sep 15, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 8133738 on suspense-hydration-compat into 283c093 on master.

@github-actions
Copy link

github-actions bot commented Oct 27, 2020

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +2% (-2.17ms - +3.92ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +1% (-1.52ms - +0.38ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -4% - +11% (-1.85ms - +5.83ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +1% (-0.05ms - +0.03ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 50
  • Built by: CI #462
  • Commit: a50b737

duration

VersionAvg timevs preact-mastervs preact-local
preact-master181.43ms - 185.71ms-unsure 🔍
-2% - +1%
-3.92ms - +2.17ms
preact-local182.29ms - 186.61msunsure 🔍
-1% - +2%
-2.17ms - +3.92ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.57ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.57ms - 3.57msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
03_update10th1k_x16
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 90
  • Built by: CI #462
  • Commit: a50b737

duration

VersionAvg timevs preact-mastervs preact-local
preact-master30.87ms - 32.21ms-unsure 🔍
-1% - +5%
-0.38ms - +1.52ms
preact-local30.30ms - 31.64msunsure 🔍
-5% - +1%
-1.52ms - +0.38ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.52ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
many_updates
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 70
  • Built by: CI #462
  • Commit: a50b737

duration

VersionAvg timevs preact-mastervs preact-local
preact-master50.30ms - 55.98ms-unsure 🔍
-10% - +3%
-5.83ms - +1.85ms
preact-local52.55ms - 57.71msunsure 🔍
-4% - +11%
-1.85ms - +5.83ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 50
  • Built by: CI #462
  • Commit: a50b737

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.08ms - 3.13ms-unsure 🔍
-1% - +2%
-0.03ms - +0.05ms
preact-local3.06ms - 3.12msunsure 🔍
-2% - +1%
-0.05ms - +0.03ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.82ms - 0.82msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the tests 👍

@marvinhagemeister
Copy link
Member

@andrewiggins should we go ahead and merge this so that we have a common branch to develop from? I have a feeling we may experiment with implementations and having it in master would make it easier to rebase stuff.

@marvinhagemeister marvinhagemeister marked this pull request as ready for review November 11, 2020 11:55
@marvinhagemeister marvinhagemeister merged commit e247e47 into master Nov 11, 2020
@marvinhagemeister marvinhagemeister deleted the suspense-hydration-compat branch November 11, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants