Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prototype spies not being reset in tests #2823

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

marvinhagemeister
Copy link
Member

Looks like we never reset previous spies which lead to the failures experienced in #2755 .

@github-actions
Copy link

github-actions bot commented Nov 11, 2020

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -0% - +2% (-0.54ms - +4.96ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +4% (-1.54ms - +1.33ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -6% - +8% (-2.92ms - +4.15ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +5% (-0.05ms - +0.15ms)
    preact-local vs preact-master

window.usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 50
  • Built by: CI #459
  • Commit: adb2be3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master199.52ms - 203.59ms-unsure 🔍
-2% - +0%
-4.96ms - +0.54ms
preact-local201.92ms - 205.62msunsure 🔍
-0% - +2%
-0.54ms - +4.96ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.56ms - 3.57ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.57ms - 3.57msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
03_update10th1k_x16
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 50
  • Built by: CI #459
  • Commit: adb2be3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.37ms - 33.36ms-unsure 🔍
-4% - +5%
-1.33ms - +1.54ms
preact-local31.23ms - 33.30msunsure 🔍
-5% - +4%
-1.54ms - +1.33ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.50ms - 3.51ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.51ms - 3.51msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
many_updates
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 70
  • Built by: CI #459
  • Commit: adb2be3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master50.29ms - 55.14ms-unsure 🔍
-8% - +5%
-4.15ms - +2.92ms
preact-local50.76ms - 55.91msunsure 🔍
-6% - +8%
-2.92ms - +4.15ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 86.0.4240.183
  • Sample size: 150
  • Built by: CI #459
  • Commit: adb2be3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.05ms - 3.10ms-unsure 🔍
-5% - +2%
-0.15ms - +0.05ms
preact-local3.03ms - 3.22msunsure 🔍
-2% - +5%
-0.05ms - +0.15ms
-

window.usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.82ms - 0.82msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c8bbe39 on spy-reset into b8b42b3 on master.

@github-actions
Copy link

Size Change: 0 B

Total Size: 41.7 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.18 kB 0 B
compat/dist/compat.module.js 3.19 kB 0 B
compat/dist/compat.umd.js 3.24 kB 0 B
debug/dist/debug.js 3.12 kB 0 B
debug/dist/debug.module.js 3.11 kB 0 B
debug/dist/debug.umd.js 3.21 kB 0 B
devtools/dist/devtools.js 184 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 4.02 kB 0 B
dist/preact.min.js 4.05 kB 0 B
dist/preact.module.js 4.04 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 305 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 373 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 283c093 into master Nov 11, 2020
@marvinhagemeister marvinhagemeister deleted the spy-reset branch November 11, 2020 11:37
@developit
Copy link
Member

Nice catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants