Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of keyed children #3359

Closed
wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Member

fixes #2619
fixes #2783

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: slower ❌ 33% - 37% (57.51ms - 63.42ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-1.66ms - +0.76ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-2.90ms - +5.19ms)
    preact-local vs preact-master
  • filter_list: slower ❌ 15% - 18% (4.07ms - 5.03ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -4% - +8% (-7.56ms - +17.51ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -3% - +5% (-1.28ms - +1.80ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.04ms - +0.03ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: slower ❌ 0% - 1% (0.01ms - 0.02ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-0.04ms - +0.05ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master168.64ms - 172.52ms-faster ✔
25% - 27%
57.51ms - 63.42ms
preact-local228.82ms - 233.27msslower ❌
33% - 37%
57.51ms - 63.42ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.47ms - 3.48ms-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.49ms - 3.50msslower ❌
0% - 1%
0.01ms - 0.02ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master58.33ms - 60.89ms-unsure 🔍
-2% - +3%
-1.35ms - +1.72ms
preact-local58.58ms - 60.26msunsure 🔍
-3% - +2%
-1.72ms - +1.35ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master87.21ms - 89.81ms-faster ✔
35% - 38%
49.09ms - 53.57ms
preact-local138.01ms - 141.66msslower ❌
55% - 61%
49.09ms - 53.57ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master78.31ms - 85.80ms-faster ✔
38% - 44%
51.02ms - 61.16ms
preact-local134.73ms - 141.56msslower ❌
60% - 77%
51.02ms - 61.16ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master65.90ms - 73.28ms-faster ✔
43% - 49%
54.10ms - 62.50ms
preact-local125.89ms - 129.89msslower ❌
74% - 94%
54.10ms - 62.50ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master88.19ms - 92.06ms-faster ✔
34% - 38%
47.32ms - 55.43ms
preact-local137.94ms - 145.06msslower ❌
52% - 62%
47.32ms - 55.43ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master62.80ms - 65.18ms-faster ✔
48% - 50%
59.53ms - 63.94ms
preact-local123.86ms - 127.58msslower ❌
92% - 101%
59.53ms - 63.94ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.99ms - 35.67ms-unsure 🔍
-2% - +5%
-0.76ms - +1.66ms
preact-local33.51ms - 35.26msunsure 🔍
-5% - +2%
-1.66ms - +0.76ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.40ms - 3.40ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.40ms - 3.40msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1271.34ms - 1276.81ms-unsure 🔍
-0% - +0%
-5.19ms - +2.90ms
preact-local1272.24ms - 1278.19msunsure 🔍
-0% - +0%
-2.90ms - +5.19ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.32ms - 25.33ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.32ms - 25.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master27.42ms - 28.04ms-faster ✔
13% - 15%
4.07ms - 5.03ms
preact-local31.92ms - 32.64msslower ❌
15% - 18%
4.07ms - 5.03ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.54ms - 1.55ms-unsure 🔍
-0% - -0%
-0.01ms - -0.01ms
preact-local1.55ms - 1.55msunsure 🔍
+0% - +0%
+0.01ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master201.36ms - 220.16ms-unsure 🔍
-8% - +3%
-17.51ms - +7.56ms
preact-local207.44ms - 224.03msunsure 🔍
-4% - +8%
-7.56ms - +17.51ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.17ms - 6.23ms-unsure 🔍
-1% - +1%
-0.05ms - +0.04ms
preact-local6.17ms - 6.23msunsure 🔍
-1% - +1%
-0.04ms - +0.05ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master36.39ms - 38.60ms-unsure 🔍
-5% - +3%
-1.80ms - +1.28ms
preact-local36.68ms - 38.83msunsure 🔍
-3% - +5%
-1.28ms - +1.80ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.61ms - 4.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.61ms - 4.61msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.79ms - 2.84ms-unsure 🔍
-1% - +1%
-0.03ms - +0.04ms
preact-local2.79ms - 2.83msunsure 🔍
-1% - +1%
-0.04ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.78ms - 0.78ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.78ms - 0.78msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.627% when pulling aeed359 on perf-improvent-keyed into 8ce72fc on master.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Size Change: -6 B (0%)

Total Size: 42.2 kB

Filename Size Change
dist/preact.min.js 4 kB -2 B (0%)
dist/preact.module.js 3.99 kB -3 B (0%)
dist/preact.umd.js 4.03 kB -1 B
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.46 kB 0 B
compat/dist/compat.module.js 3.44 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
dist/preact.js 3.97 kB 0 B
hooks/dist/hooks.js 1.17 kB 0 B
hooks/dist/hooks.module.js 1.18 kB 0 B
hooks/dist/hooks.umd.js 1.24 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants