replace isConnected with parentDom.contains #4421

JoviDeCroock · 2024-06-24T14:00:59Z

Fixes #4415

#4194 still works correctly and this solves the IE11 not having isConected

github-actions · 2024-06-24T14:01:16Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +2% (-8.45ms - +15.30ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -2% - +2% (-0.25ms - +0.30ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -2% - +2% (-1.74ms - +1.80ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -2% - +5% (-0.35ms - +0.79ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +4% (-0.64ms - +3.30ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -4% - +2% (-0.09ms - +0.04ms)
^{preact-local vs preact-main}
todo: slower ❌ 0% - 2% (0.08ms - 0.51ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -5% - +0% (-1.53ms - +0.14ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.02ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -4% - +0% (-0.48ms - +0.00ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	880.70ms - 898.72ms	-	unsure 🔍 -1% - +2% -8.45ms - +15.30ms
preact-main	878.56ms - 894.01ms	unsure 🔍 -2% - +1% -15.30ms - +8.45ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 25.17ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.02ms
preact-main	25.15ms - 25.15ms	unsure 🔍 -0% - +0% -0.02ms - +0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.63ms - 16.99ms	-	unsure 🔍 -2% - +2% -0.25ms - +0.30ms
preact-main	16.58ms - 17.00ms	unsure 🔍 -2% - +2% -0.30ms - +0.25ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.69ms - 1.69ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.69ms - 1.69ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	75.15ms - 77.50ms	-	unsure 🔍 -2% - +2% -1.74ms - +1.80ms
preact-main	74.97ms - 77.62ms	unsure 🔍 -2% - +2% -1.80ms - +1.74ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	13.11ms - 13.31ms	-	unsure 🔍 -4% - +0% -0.48ms - +0.00ms
preact-main	13.22ms - 13.67ms	unsure 🔍 -0% - +4% -0.00ms - +0.48ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.80ms - 17.63ms	-	unsure 🔍 -2% - +5% -0.35ms - +0.79ms
preact-main	16.61ms - 17.38ms	unsure 🔍 -5% - +2% -0.79ms - +0.35ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.61ms - 4.62ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.61ms - 4.62ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	80.41ms - 83.08ms	-	unsure 🔍 -1% - +4% -0.64ms - +3.30ms
preact-main	78.97ms - 81.87ms	unsure 🔍 -4% - +1% -3.30ms - +0.64ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.56ms - 3.59ms	-	unsure 🔍 -1% - +0% -0.02ms - +0.01ms
preact-main	3.57ms - 3.60ms	unsure 🔍 -0% - +1% -0.01ms - +0.02ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.71ms - 30.47ms	-	unsure 🔍 -3% - +1% -0.80ms - +0.39ms
preact-main	29.84ms - 30.75ms	unsure 🔍 -1% - +3% -0.39ms - +0.80ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.68ms - 37.68ms	-	unsure 🔍 -3% - +4% -1.21ms - +1.51ms
preact-main	35.60ms - 37.45ms	unsure 🔍 -4% - +3% -1.51ms - +1.21ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.76ms - 27.45ms	-	unsure 🔍 -2% - +2% -0.53ms - +0.42ms
preact-main	26.83ms - 27.49ms	unsure 🔍 -2% - +2% -0.42ms - +0.53ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.91ms - 33.89ms	-	unsure 🔍 -1% - +7% -0.41ms - +2.21ms
preact-main	31.14ms - 32.86ms	unsure 🔍 -7% - +1% -2.21ms - +0.41ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.97ms - 24.49ms	-	unsure 🔍 -9% - +1% -2.17ms - +0.34ms
preact-main	23.65ms - 25.65ms	unsure 🔍 -2% - +9% -0.34ms - +2.17ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.24ms - 26.49ms	-	unsure 🔍 -2% - +6% -0.40ms - +1.41ms
preact-main	24.71ms - 26.01ms	unsure 🔍 -5% - +2% -1.41ms - +0.40ms	-

text-update

Browser: chrome-headless
Sample size: 110
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.97ms - 2.06ms	-	unsure 🔍 -4% - +2% -0.09ms - +0.04ms
preact-main	1.99ms - 2.08ms	unsure 🔍 -2% - +4% -0.04ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 0.98ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	0.98ms - 0.98ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.37ms - 27.68ms	-	slower ❌ 0% - 2% 0.08ms - 0.51ms
preact-main	27.08ms - 27.38ms	faster ✔ 0% - 2% 0.08ms - 0.51ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: Benchmarks #1548
Commit: cc839df

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.13ms - 31.96ms	-	unsure 🔍 -5% - +0% -1.53ms - +0.14ms
preact-main	31.52ms - 32.97ms	unsure 🔍 -0% - +5% -0.14ms - +1.53ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.55ms - 3.55ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	3.55ms - 3.55ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2024-06-24T14:02:10Z

Size Change: +30 B (+0.05%)

Total Size: 61.8 kB

Filename	Size	Change
`compat/dist/compat.js`	4.1 kB	+11 B (+0.27%)
`compat/dist/compat.module.js`	4.03 kB	+11 B (+0.27%)
`compat/dist/compat.umd.js`	4.17 kB	+15 B (+0.36%)
`dist/preact.js`	4.67 kB	-1 B (-0.02%)
`dist/preact.min.js`	4.7 kB	-2 B (-0.04%)
`dist/preact.min.umd.js`	4.73 kB	-3 B (-0.06%)
`dist/preact.umd.js`	4.75 kB	-1 B (-0.02%)

ℹ️ View Unchanged

Filename	Size
`debug/dist/debug.js`	3.7 kB
`debug/dist/debug.module.js`	3.71 kB
`debug/dist/debug.umd.js`	3.78 kB
`devtools/dist/devtools.js`	259 B
`devtools/dist/devtools.module.js`	273 B
`devtools/dist/devtools.umd.js`	345 B
`dist/preact.min.module.js`	4.7 kB
`dist/preact.module.js`	4.7 kB
`hooks/dist/hooks.js`	1.56 kB
`hooks/dist/hooks.module.js`	1.59 kB
`hooks/dist/hooks.umd.js`	1.63 kB
`jsx-runtime/dist/jsxRuntime.js`	981 B
`jsx-runtime/dist/jsxRuntime.module.js`	956 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.06 kB
`test-utils/dist/testUtils.js`	451 B
`test-utils/dist/testUtils.module.js`	456 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

coveralls · 2024-06-24T14:08:06Z

coverage: 99.611%. remained the same
when pulling 4d2ac43 on use-contains
into 4c20c23 on main.

coveralls · 2024-06-24T14:08:12Z

coverage: 99.611%. remained the same
when pulling 4d2ac43 on use-contains
into 4c20c23 on main.

coveralls · 2024-06-25T13:49:55Z

coverage: 99.611%. remained the same
when pulling cc839df on use-contains
into 92e86e9 on main.

coveralls · 2024-06-25T13:49:55Z

coverage: 99.611%. remained the same
when pulling cc839df on use-contains
into 92e86e9 on main.

…to DOM issues See the following for the changes introduced which might have caused this: - preactjs/preact#4409 - preactjs/preact#4421 - preactjs/preact#4403

towry · 2024-08-15T06:05:28Z

This commit breaks things.

TypeError: n2.contains is not a function

according to this information: netzo/dsa@dcc0bb4

10.22.0 works.

marvinhagemeister · 2024-08-15T07:16:37Z

@towry Using .contains() is a standard DOM API that's been around for ages. Fresh 1.x hasn't been updated yet. The issue you're looking for is denoland/fresh#2587

marvinhagemeister · 2024-08-15T07:40:47Z

@towry I've just cut a new Fresh release. Please upgrade to Fresh 1.7.1 which resolves this issue in your project.

JoviDeCroock marked this pull request as ready for review June 24, 2024 14:06

JoviDeCroock requested review from developit, andrewiggins and marvinhagemeister June 24, 2024 14:06

JoviDeCroock added 2 commits June 25, 2024 15:47

replace isConnected with parentDom.contains

709db09

add contains

cc839df

JoviDeCroock force-pushed the use-contains branch from 4d2ac43 to cc839df Compare June 25, 2024 13:47

marvinhagemeister approved these changes Jun 25, 2024

View reviewed changes

JoviDeCroock merged commit eb37677 into main Jun 25, 2024
13 checks passed

JoviDeCroock deleted the use-contains branch June 25, 2024 15:28

JoviDeCroock mentioned this pull request Jun 30, 2024

10.22.1 #4428

Merged

X-oss-byte mentioned this pull request Jul 22, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.22.1 X-oss-byte/next-auth#107

Open

lorenzoAtBEIS mentioned this pull request Aug 10, 2024

[Snyk] Upgrade preact from 10.22.0 to 10.22.1 UKGovernmentBEIS/inspect_ai#228

Merged

ZeroXClem mentioned this pull request Aug 12, 2024

[Snyk] Upgrade preact from 10.20.1 to 10.22.1 ZeroXClem/metamesa#4

Closed

X-oss-byte mentioned this pull request Aug 14, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.0 X-oss-byte/next-auth#109

Open

towry mentioned this pull request Aug 15, 2024

不兼容 preact >= 10.22.1 NervJS/taro#16315

Open

X-oss-byte mentioned this pull request Aug 15, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.1 X-oss-byte/next-auth#110

Open

ramzimalhas mentioned this pull request Aug 22, 2024

[Snyk] Upgrade preact from 10.11.3 to 10.23.1 ramzimalhas/chatgpt-advanced#2

Open

replace isConnected with parentDom.contains #4421

replace isConnected with parentDom.contains #4421

Conversation

JoviDeCroock commented Jun 24, 2024 • edited Loading

github-actions bot commented Jun 24, 2024 • edited Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

github-actions bot commented Jun 24, 2024 • edited Loading

coveralls commented Jun 24, 2024

coveralls commented Jun 24, 2024

coveralls commented Jun 25, 2024

coveralls commented Jun 25, 2024

towry commented Aug 15, 2024

marvinhagemeister commented Aug 15, 2024

marvinhagemeister commented Aug 15, 2024

JoviDeCroock commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 24, 2024 •

edited

Loading