Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computed updated despite no dependencies having changed #150

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

marvinhagemeister
Copy link
Member

Fixes #124

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

🦋 Changeset detected

Latest commit: e187b63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit e187b63
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/632346391c82880009c7f016
😎 Deploy Preview https://deploy-preview-150--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

Size Change: +340 B (+1%)

Total Size: 66 kB

Filename Size Change
docs/dist/assets/client.********.js 45.8 kB +1 B (0%)
docs/dist/assets/index.********.js 1.08 kB +240 B (+29%) 🚨
docs/dist/assets/signals-core.module.********.js 971 B +39 B (+4%)
docs/dist/assets/signals.module.********.js 1.95 kB -1 B (0%)
docs/dist/basic-********.js 245 B +1 B (0%)
docs/dist/demos-********.js 3.35 kB +1 B (0%)
docs/dist/nesting-********.js 1.13 kB +1 B (0%)
docs/dist/react-********.js 239 B +1 B (0%)
packages/core/dist/signals-core.js 1.01 kB +30 B (+3%)
packages/core/dist/signals-core.mjs 815 B +27 B (+3%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
packages/preact/dist/signals.js 1.12 kB
packages/preact/dist/signals.mjs 1.11 kB
packages/react/dist/signals.js 831 B
packages/react/dist/signals.mjs 791 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit dfb3a71 into main Sep 15, 2022
@marvinhagemeister marvinhagemeister deleted the unmarked-computed branch September 15, 2022 15:38
@github-actions github-actions bot mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A computed value is updated even when all of its dependencies haven't changed.
2 participants