Optimize dependency value change checks by allowing earlier exists from the loop #209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the dependency version change check used by computed & effect. Before the change each dependency's
._refresh()
was called before checking the dependency's version number. After this change the version number is checked first, then._refresh()
is called, and then the version number is checked again. In practice this allows the dependency checks break the loop earlier, avoiding calls to_refresh()
for a) plain signals that have changed and b) computed values that get repeated reads.The following benchmark demonstrates the impact in a scenario that contains both a) and b):
The results before the change:
And after the change: