Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod build #28

Merged
merged 17 commits into from
Jun 15, 2020
Merged

Prod build #28

merged 17 commits into from
Jun 15, 2020

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jun 14, 2020

This is the start for a production-ready build.

Do we have any requirements set for this?

src/bundler.js Outdated Show resolved Hide resolved
src/bundler.js Outdated Show resolved Hide resolved
src/bundler.js Outdated Show resolved Hide resolved
@developit
Copy link
Member

developit commented Jun 14, 2020

Thinking we can make our lives easier by moving away from index.js for both entrypoints here:

src/
    cli.js      # import { start } from './start.js'; import { build } from './build.js;
    start.js    # import { bundleDev }  from './bundler.js';
    build.js    # import { bundleProd }  from './bundler.js';
    bundler.js  # export { bundleDev, bundleProd }

@developit developit merged commit e6ef270 into master Jun 15, 2020
@developit developit deleted the prod-build branch June 15, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants