Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iso] Router: pass route params as props when no prop with that name exists #586

Merged
merged 9 commits into from Aug 31, 2021

Conversation

developit
Copy link
Member

why not both?

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2021

🦋 Changeset detected

Latest commit: c963fbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-iso Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@developit developit added the DRAFT Draft, not ready for merging label May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Size Change: +18 B (0%)

Total Size: 5.97 kB

Filename Size Change
packages/preact-iso/.dist/index.********.js 1.58 kB +3 B (0%)
packages/preact-iso/.dist/prerender.********.js 347 B -1 B (0%)
packages/preact-iso/router.js 2.33 kB +16 B (+1%)
ℹ️ View Unchanged
Filename Size
packages/preact-iso/hydrate.js 290 B
packages/preact-iso/index.js 195 B
packages/preact-iso/lazy.js 594 B
packages/preact-iso/prerender.js 629 B

compressed-size-action

@Inviz
Copy link
Contributor

Inviz commented Jun 2, 2021

I like

@developit developit marked this pull request as ready for review August 31, 2021 17:48
@developit developit changed the title [draft] possible "why not both" solution for route param-to-prop mapping [iso] Router: pass route params as props when no prop with that name exists Aug 31, 2021
@marvinhagemeister marvinhagemeister merged commit 44bd683 into main Aug 31, 2021
@marvinhagemeister marvinhagemeister deleted the route-params-possibility branch August 31, 2021 21:12
@github-actions github-actions bot mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DRAFT Draft, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants